Inject meta viewport tag for Android WPT test runs
Categories
(Testing :: web-platform-tests, enhancement)
Tracking
(Not tracked)
People
(Reporter: dshin, Unassigned)
Details
Not having it specified causes us to render the document and then scale it down to viewport size, causing rounding errors that lead to off-by-one failures: See Bug 1768921 Comment 14.
Could add tags-as-necessary, but would be nice if we could somehow globally inject it? Not sure what the impact of that may be.
|
||
Comment 1•1 year ago
•
|
||
I suspect we shouldn't do this, because:
A) it doesn't make a difference for most tests
B) For tests where it does make a justifiable difference, we can just add the meta viewport tag (like we currently do sometimes)
C) it's important to have the ability to explicitly write tests WPT tests that (on Android) test the (currently-default) "no-viewport-meta-tag" behavior, with the big-viewport-getting-scaled-down behavior. If we were to do what comment 0 suggests and add the viewport meta tag automatically somehow, I think we'd have to come up with some new syntax for tests to opt out of that, which would be a bit clumsy.
If we had good reasons to move forward here, though, we'd also need to convince other browser vendors and do this broadly, because otherwise we'd end up with somebody checking in tests that have different results in Firefox vs. other browsers, due to differences in the viewport sizing (e.g. due to content that ends up offscreen and hence doesn't-get-reftest-snapshotted when we run the test with a meta viewport tag)
|
Reporter | |
Comment 2•1 year ago
|
||
Right, I guess there could be other implications here that we want to explicitly test for.
I will probably add the the viewport tag to the linked failure test, but in a separate ticket to document this rationale.
Description
•