1930284 - Clean up toolbox color declarations.

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1930284 - Clean up toolbox color variables. r=#theme

While writing bug 1928151, I realized we really don't need the separate
non-lwt versions of this. We only use them to set the general variables,
so they can just go away.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1930284 - Also clean-up toolbar color variables. r=#theme

Unlike the previous patch this does change behavior, but I think it's
fine.

The reason we used the non-lwt toolbar colors for customize mode is to
guarantee full opacity, see bug 1762379 and bug 1765685.

However, we need to do the same on the sidebar, and there we chose a
more theme-friendly way of doing that, which allows this simplification.

So do that instead.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2fd6f284a05
Clean up toolbox color variables. r=desktop-theme-reviewers,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8fbcb70a97d
Also clean-up toolbar color variables. r=desktop-theme-reviewers,dao

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c2fd6f284a05
https://hg.mozilla.org/mozilla-central/rev/b8fbcb70a97d