1930637 - Tracer sidebar crashes: can't access property "functionDisplayName", frame is undefined

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

STR are not super clear.

• On https://nchevobbe.github.io/demo/console-test-app.html
• Making sure it didn't start with the debugger
• Start profiling clicking on the trace button
• Go to the content page and try to click on a few button

-> crash

Error:
TypeError: can't access property "functionDisplayName", frame is undefined

React Component Stack:
in Frame
in div
in div
in TreeNodeClass
in div
in Tree
in div
in div
in Panel
in div
in div
in div
in Tabs
in div
in Tracer
in Connect(Tracer)
in AppErrorBoundary
in div
in Panel
in div
in div
in div
in Tabs
in aside
in PrimaryPanes
in Connect(PrimaryPanes)
in div
in div
in SplitBox
in div
in div
in SplitBox
in AppErrorBoundary
in div
in App
in Connect(App)
in Provider
in Provider

Stacktrace:
#renderFunctionDisplayName@resource://devtools/client/shared/components/Frame.js:359:33
render@resource://devtools/client/shared/components/Frame.js:379:38
finishClassComponent@resource://devtools/client/shared/vendor/react-dom.js:10638:31
updateClassComponent@resource://devtools/client/shared/vendor/react-dom.js:10601:44
beginWork@resource://devtools/client/shared/vendor/react-dom.js:11419:16
performUnitOfWork@resource://devtools/client/shared/vendor/react-dom.js:14702:12
workLoop@resource://devtools/client/shared/vendor/react-dom.js:14720:24
renderRoot@resource://devtools/client/shared/vendor/react-dom.js:14803:15
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15655:17
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:38:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:84:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
addTraces/<@resource://devtools/client/debugger/src/actions/tracing.js:51:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
bindActionCreator/<@resource://devtools/client/shared/vendor/redux.js:520:12
_notifyWatchers@resource://devtools/shared/commands/resource/resource-command.js:915:24
throttledFunction@resource://devtools/shared/throttle.js:50:21
_onResourceAvailableArray@resource://devtools/shared/commands/resource/resource-command.js:731:12
_emit@resource://devtools/shared/event-emitter.js:242:32
emit@resource://devtools/shared/event-emitter.js:186:18
emit@resource://devtools/shared/event-emitter.js:330:18
onPacket@resource://devtools/shared/protocol/Front.js:348:13
onPacket@resource://devtools/client/devtools-client.js:478:13
send/<@resource://devtools/shared/transport/local-transport.js:73:25
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22

---

I couldn't reproduce a second time, even restarting the toolbox, so it looks pretty racy?
This looks different than another crash that I filed recently (Bug 1927399)

Comment 1

[Julian Descottes [:jdescottes]]

Might be related to a reload, but we can probably fix the stacktrace regardless.