1930706 - Clean up lint-baseline.xml unused resources

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, task)

Description

[:Gela]

To avoid the linter failing for now, some resources are marked as unused to ignore warnings but once those are in use we need to clean up and remove this bit:

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_pick_a_theme appears to be unused">
        <location file="src/main/res/drawable/ic_pick_a_theme.xml" />
    </issue>

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_pick_a_theme_dark appears to be unused">
        <location file="src/main/res/drawable/ic_pick_a_theme_dark.xml" />
    </issue>

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_pick_a_theme_light appears to be unused">
        <location file="src/main/res/drawable/ic_pick_a_theme_light.xml" />
    </issue>

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_pick_a_theme_system_auto appears to be unused">
        <location file="src/main/res/drawable/ic_pick_a_theme_system_auto.xml" />
    </issue>

Also this bit:

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_onboarding_customize_toolbar appears to be unused">
        <location file="src/main/res/drawable/ic_onboarding_customize_toolbar.xml" />
    </issue>

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_onboarding_bottom_toolbar appears to be unused">
        <location file="src/main/res/drawable/ic_onboarding_bottom_toolbar.xml" />
    </issue>

    <issue id="UnusedResources"
        message="The resource R.drawable.ic_onboarding_top_toolbar appears to be unused">
        <location file="src/main/res/drawable/ic_onboarding_top_toolbar.xml" />
    </issue>

Comment 1

[:Gela]

Attachment: Bug 1930706 - Clean up lint-baseline.xml unused resources

Since the assets related to theme selection in onboarding are now in use, we
can safely remove the linter overrides

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a485bec198a
Clean up lint-baseline.xml unused resources r=android-reviewers,twhite,tjorjani

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6a485bec198a