1930777 - ruff: xpidl/header.py: Use `elif` instead of `else` then `if`, to reduce indentation

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

Use elif instead of else then if, to reduce indentation
https://searchfox.org/mozilla-central/source/xpcom/idl-parser/xpidl/header.py#85-89
https://searchfox.org/mozilla-central/source/xpcom/idl-parser/xpidl/header.py#149

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by https://docs.astral.sh/ruff/rules/collapsible-else-if/

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[giulianoverrando]

Attachment: Bug 1930777 - Changed `if` then `else` with `elif` to reduce indentation. r=sylvestre

Comment 2

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:giulianoverrando, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/028131817103
Changed `if` then `else` with `elif` to reduce indentation. r=sylvestre

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/028131817103