193090 - Remove MOZILLA_BSAFE_BUILD and blapi_bsf.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P4)

Description

[Nelson Bolyard (seldom reads bugmail)]

Once upon a time, NSS's implementation of the BLAPI API was really just a 
wrapper for RSA Security's BSAFE Crypto-C library.  At some point in late 
2000, NSS switched to its own complete BLAPI implementation.  The wrapper 
code for BSAFE, blapi_bsf.c, remained in lib/freebl, and for a while, both 
implementations of blapi were interchangable.  But in the last year or so, 
the BLAPI API has been expanded with the addition of new functions, and no 
implementation of these functions has been added to blapi_bsf.c.  Consequently, 
blapi_bsf.c no longer fully implements the BLAPI API and is not usable with 
recent releases of NSS.  It should probably be removed from lib/freebl.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Taking P4 bug

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch to stop building MOZILLA_BSAFE_BUILD

In addition to this patch, I would cvs remove these files from nss/lib/freebl:
   blapi_bsf.c	dh_bsf.c fblstdlib.c

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Before I check this in, I just want to be sure that nobody at Sun or AOL 
wants to keep the old MOZILLA_BSAFE_BUILD capability around.

Comment 4

[Wan-Teh Chang]

Yes, it is OK to remove MOZILLA_BSAFE_BUILD.

Comment 5

[Ian McGreer]

Comment on attachment 123364 [details] [diff] [review]
patch to stop building MOZILLA_BSAFE_BUILD


OK with me to remove this.

Comment 6

[Wan-Teh Chang]

Comment on attachment 123364 [details] [diff] [review]
patch to stop building MOZILLA_BSAFE_BUILD

r=wtc.	There are other mentions of MOZILLA_BSAFE_BUILD that
can also be removed.  I believe they are in the softoken
directory and cmd/platlibs.mk.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

/cvsroot/mozilla/security/nss/lib/freebl/Makefile,v  <--  Makefile
new revision: 1.48; previous revision: 1.47

/cvsroot/mozilla/security/nss/lib/freebl/manifest.mn,v  <--  manifest.mn
new revision: 1.32; previous revision: 1.31

/cvsroot/mozilla/security/nss/lib/freebl/blapi_bsf.c,v  <--  blapi_bsf.c
new revision: delete; previous revision: 1.8

/cvsroot/mozilla/security/nss/lib/freebl/dh_bsf.c,v  <--  dh_bsf.c
new revision: delete; previous revision: 1.1

/cvsroot/mozilla/security/nss/lib/freebl/fblstdlib.c,v  <--  fblstdlib.c
new revision: delete; previous revision: 1.2

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Also removed MOZILLA_BSAFE_BUILD from softoken/manifest.mn

/cvsroot/mozilla/security/nss/lib/softoken/config.mk,v  <--  config.mk
new revision: 1.14; previous revision: 1.13