1930962 - [wpt-sync] Sync PR 49146 - Fix crash when @position-try invalidates display:none

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49146 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49146
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Fix crash when @position-try invalidates display:none

The expectation was that OutOfFlowData is nuked from a node when it is
no longer rendered, but that is not the case.

Null check LayoutObject before accessing it.

Bug: 377324991
Change-Id: I5984a8d528667dd95d73edba7c764fedd7c582fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017885
Commit-Queue: Rune Lillesveen \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1382313}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=31ba36594c9566d034e4980d0d424e92431c04a7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1
TIMEOUT: 1

Chrome

CRASH : 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/chrome-377324991-crash.html [wpt.fyi]: PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: CRASH, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df8bbf710638
[wpt PR 49146] - Fix crash when @position-try invalidates display:none, a=testonly

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/df8bbf710638