Closed Bug 1930963 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 49148 - Delay clamping calc() values in filter properties until computed value time.

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49148 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49148
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Delay clamping calc() values in filter properties until computed value time.

This fixes a crash when we have sign() with something complicated
on the inside.

Change-Id: I51fb2309472baac69c96eaf0d347982986710dc4

Reviewed-on: https://chromium-review.googlesource.com/6018425
WPT-Export-Revision: b64b6dee19272bb975193ae296f6e79cca77141a

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 39 subtests

Status Summary

Firefox

OK : 2
PASS: 71
FAIL: 2

Chrome

OK : 2
PASS: 72
FAIL: 1

Safari

OK : 2
PASS: 73

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/filter-effects/parsing/filter-parsing-valid.html [wpt.fyi]
    • e.style['filter'] = "grayscale(calc(300%))" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
    • e.style['filter'] = "grayscale(calc(101% * sign(1em - 1px)))" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4023383d5a36 [wpt PR 49148] - Delay clamping calc() values in filter properties until computed value time., a=testonly https://hg.mozilla.org/integration/autoland/rev/4ee48c28c8dc [wpt PR 49148] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4023383d5a36
https://hg.mozilla.org/mozilla-central/rev/4ee48c28c8dc

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.