1931082 - [wpt-sync] Sync PR 49155 - Fix solid color thumb quad under large scale

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49155 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49155
Details from upstream follow.

Xianzhu Wang <[e-mail]> wrote:

Fix solid color thumb quad under large scale

If a layer has a large scale, visible_layer_rect() can't reliably
clip a quad before scaling because a "pixel" in the layer is very
large and scale-after-clip will create a quad exceeding the clip.

clip
large-scale
layer

Now share more code with the non-solid-color-thumb code path.

For a AppendQuads method, to ensure the clip rect is applied, it's
better to call PopulateScaledSharedQuadState() instead of creating a
shared quad state by itself.

Bug: 377948403
Change-Id: I8d7dd08fe9fc7907685bfbaa1a5fd5682688aed0

Reviewed-on: https://chromium-review.googlesource.com/6014683
WPT-Export-Revision: 7523ad2d19e065a38cdf97e8c2f5b7911b210564

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=28f46918929e2531c9ea1183c244bc7a42cfd7e4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22658c926a94
[wpt PR 49155] - Fix solid color thumb quad under large scale, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/22658c926a94