Closed Bug 1931226 Opened 21 days ago Closed 18 days ago

[wpt-sync] Sync PR 49161 - Make customizable select <button> display:contents

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49161 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49161
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Make customizable select <button> display:contents

This patch makes the \<select> element itself handle focus, interaction,
and box decorations instead of the child \<button> element. This removes
a lot of complexity, including delegatesFocus, divergent event handling
and button testing, and :-internal-select-has-child-button.

This was discussed here:
https://github.com/w3c/csswg-drafts/issues/10857

Change-Id: Ia036c6dc08be1b86a50bd96239d08ad19c9a7a6b

Reviewed-on: https://chromium-review.googlesource.com/6001193
WPT-Export-Revision: 716afdb0358954fc594b0cb358bfd56cbf4d7d88

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 6 subtests

Status Summary

Firefox

OK : 4
PASS : 1
FAIL : 10
ERROR : 1
NOTRUN: 9

Chrome

OK : 5
PASS : 12
FAIL : 8

Safari

OK : 4
PASS : 1
FAIL : 10
ERROR : 1
NOTRUN: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/forms/the-select-element/customizable-select/button-in-popover.tentative.html [wpt.fyi]
    • Buttons in the popover should be rendered and should not close the popover when clicked.: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/forms/the-select-element/customizable-select/select-disabled.tentative.html [wpt.fyi]
    • defaultbutton: <select disabled> should prevent focus and activation with appearance:base-select.: FAIL (Chrome: PASS, Safari: FAIL)
    • custombutton: <select disabled> should prevent focus and activation with appearance:base-select.: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/forms/the-select-element/customizable-select/select-keyboard-behavior.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • defaultbutton: When the listbox is closed, spacebar should open the listbox.: FAIL (Chrome: PASS, Safari: FAIL)
    • defaultbutton: When the listbox is closed, all arrow keys should open the listbox.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • defaultbutton: When the listbox is closed, the enter key should submit the form or do nothing.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • defaultbutton: When the listbox is open, the enter key should commit the selected option.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • defaultbutton: When the listbox is open, the tab key should close the listbox.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • custombutton: When the listbox is closed, spacebar should open the listbox.: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • custombutton: When the listbox is closed, all arrow keys should open the listbox.: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • custombutton: When the listbox is closed, the enter key should submit the form or do nothing.: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • custombutton: When the listbox is open, the enter key should commit the selected option.: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • custombutton: When the listbox is open, the tab key should close the listbox.: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
  • /html/semantics/forms/the-select-element/customizable-select/select-mouse-behavior.tentative.html [wpt.fyi]
    • fallbackbutton: Select with appearance:base-select should open and close when clicking the button.: FAIL (Chrome: PASS, Safari: FAIL)
    • fallbackbutton: Clicking an option in an appearance:base-select select should choose the option and close the popover.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fallbackbutton: Clicking the label should focus the select button without opening the picker.: FAIL (Chrome: PASS, Safari: FAIL)
    • custombutton: Select with appearance:base-select should open and close when clicking the button.: FAIL (Chrome: PASS, Safari: FAIL)
    • custombutton: Clicking an option in an appearance:base-select select should choose the option and close the popover.: FAIL (Chrome: FAIL, Safari: FAIL)
    • custombutton: Clicking the label should focus the select button without opening the picker.: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e608711d593 [wpt PR 49161] - Make customizable select <button> display:contents, a=testonly https://hg.mozilla.org/integration/autoland/rev/f2f5fc72f2da [wpt PR 49161] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6e608711d593
https://hg.mozilla.org/mozilla-central/rev/f2f5fc72f2da

Status: NEW → RESOLVED
Closed: 18 days ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.