1931513 - QM: Eliminate the need to do conversion from PrincipalMetadata to PrincipalInfo

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P1)

Description

[Jan Varga [:janv]]

In theory, PrincipalMetadataToPrincipalInfo may occasionally return a different PrincipalInfo than the one originally used to create PrincipalMetadata. While we could add some diagnostic assertions to help identify and eventually address any inconsistencies, it would be safer to avoid this conversion entirely.

PrincipalMetadataToPrincipalInfo is currently called in QuotaManager::OpenClientDirectory:
https://searchfox.org/mozilla-central/rev/81ac0fe96e1bd6020408c2ae7eae6e5b5114d1db/dom/quota/ActorsParent.cpp#5383

If PrincipalMetadata data is not consistent with PrincipalInfo data (especially the origin string), then the tracking of initialized origins on PBackground thread and QM I/O thread will not be consistent as well.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Change origin initialization related methods to take PrincipalMetadata instead of PrincipalInfo; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Change also PersistentOriginInitialized and TemporaryOriginInitialize to take PrincipalMetadata instead of PrincipalInfo; r=#dom-storage

This is not strictly required to get rid of PrincipalMetadataToPrincipalInfo,
but it's better for consistency and readability.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Fix InitializePersistentOrigin_FinishedWithScheduledShutdown test to use correct OriginMetadata; r=#dom-storage

The persistence type should be PERSISTENCE_TYPE_PERSISTENT.

This is a preparation patch for next patches which change many methods to take
OriginMetadata instead of PersistenceType and PrincipalInfo.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Change persistent origin initialization related methods to take OriginMetadata instead of PrincipalMetadata; r=#dom-storage

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Change temporary origin initialization related methods to take OriginMetadata instead of PersistenceType and PrincipalMetadata; r=#dom-storage

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Change group initialization related methods to take PrincipalMetadata instead of PrincipalInfo; r=#dom-storage

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Change also TemporaryGroupInitialized to take PrincipalMetadata instead of PrincipalInfo; r=#dom-storage

This is not strictly required to get rid of PrincipalMetadataToPrincipalInfo,
but it's better for consistency and readability.

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1931513 - QM: Remove PrincipalMetadataToPrincipalInfo method; r=#dom-storage

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbd1c6ba8b63
QM: Fix InitializePersistentOrigin_FinishedWithScheduledShutdown test to use correct OriginMetadata; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/bb7b05353b62
QM: Change origin initialization related methods to take PrincipalMetadata instead of PrincipalInfo; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/1156ce469927
QM: Change also PersistentOriginInitialized and TemporaryOriginInitialize to take PrincipalMetadata instead of PrincipalInfo; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/233c750b54af
QM: Change persistent origin initialization related methods to take OriginMetadata instead of PrincipalMetadata; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/a3f1433213fe
QM: Change temporary origin initialization related methods to take OriginMetadata instead of PersistenceType and PrincipalMetadata; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/14394c582d84
QM: Change group initialization related methods to take PrincipalMetadata instead of PrincipalInfo; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/1713e621c7e8
QM: Change also TemporaryGroupInitialized to take PrincipalMetadata instead of PrincipalInfo; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/8900a352dd36
QM: Remove PrincipalMetadataToPrincipalInfo method; r=dom-storage-reviewers,jari

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fbd1c6ba8b63
https://hg.mozilla.org/mozilla-central/rev/bb7b05353b62
https://hg.mozilla.org/mozilla-central/rev/1156ce469927
https://hg.mozilla.org/mozilla-central/rev/233c750b54af
https://hg.mozilla.org/mozilla-central/rev/a3f1433213fe
https://hg.mozilla.org/mozilla-central/rev/14394c582d84
https://hg.mozilla.org/mozilla-central/rev/1713e621c7e8
https://hg.mozilla.org/mozilla-central/rev/8900a352dd36