Open Bug 1931571 Opened 1 year ago Updated 1 year ago

Update security approval docs to talk about re-approval for already landed patches

Categories

(Core :: Security, task)

task

Tracking

()

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

If a patch has sec-approval, then gets backed out, it does not need to get sec-approval again in order to be relanded even if the patch changes. Normally this happens implicitly, because the new patch ends up with the same differential revision, but I think it should apply even if an entirely new patch with a new differential revision is created.

Maybe on some level if the answers to the questions substantially change, then it should get re-approval, but I'm not sure if that is worth mentioning. Like if somebody adds tests that kind of changes the story, but maybe at this point in the process that is unlikely and people could do it anyways?

If the old patch gets obsoleted, then the prior sec-approval+ becomes invisible, so maybe somebody could put up a sec-approval? anyways so the bug at least looks more complete, but it needn't block landing, maybe.

You need to log in before you can comment on or make changes to this bug.