Closed Bug 1931619 Opened 26 days ago Closed 24 days ago

[wpt-sync] Sync PR 49200 - FSO: Omit changedHandle for "disappear", "error", and "unknown" events

Categories

(Core :: DOM: File, task, P4)

Product:
Core
Component:
DOM: File
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49200 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49200
Details from upstream follow.

Rahul Singh <rahsin@microsoft.com> wrote:

FSO: Omit changedHandle for "disappear", "error", and "unknown" events

This updates the changedHandle field in FileSystemChangeRecord to be
an optional. It also updates the changedHandle() getter to return a
nullptr for disappeared, errored, and unknown change types.

Bug: 377903461
Change-Id: Ie6abe56d9032dbe42aba6f893837e6a43a027980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012533
Reviewed-by: Nathan Memmott \<memmott@chromium.org>
Commit-Queue: Rahul Singh \<rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1383791}

Component: web-platform-tests → DOM: File
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 7 tests and 16 subtests

Status Summary

Firefox

OK : 4
FAIL : 34
ERROR : 3
NOTRUN: 24

Safari

OK : 4
FAIL : 34
ERROR : 3
NOTRUN: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fs/FileSystemObserver-sync-access-handle.https.tentative.worker.html [wpt.fyi]
    • FileSystemSyncAccessHandle.write produces a "modified" event: FAIL (Safari: FAIL)
    • Multiple FileSystemSyncAccessHandle.writes produces the same amount of "modified" event: FAIL (Safari: FAIL)
    • FileSystemSyncAccessHandle.truncate produces a "modified" event: FAIL (Safari: FAIL)
    • FileSystemSyncAccessHandle methods that don't modify the file don't produce events: FAIL (Safari: FAIL)
  • /fs/FileSystemObserver-writable-file-stream.https.tentative.any.sharedworker.html [wpt.fyi]
    • Closing a FileSystemWritableFileStream that's modified the file produces a "modified" event: FAIL (Safari: FAIL)
    • All FileSystemWritableFileStream methods that aren't closed don't produce events: FAIL (Safari: FAIL)
  • /fs/FileSystemObserver-writable-file-stream.https.tentative.any.worker.html [wpt.fyi]
    • Closing a FileSystemWritableFileStream that's modified the file produces a "modified" event: FAIL (Safari: FAIL)
    • All FileSystemWritableFileStream methods that aren't closed don't produce events: FAIL (Safari: FAIL)
  • /fs/FileSystemObserver-writable-file-stream.https.tentative.any.html [wpt.fyi]
    • Closing a FileSystemWritableFileStream that's modified the file produces a "modified" event: FAIL (Safari: FAIL)
    • All FileSystemWritableFileStream methods that aren't closed don't produce events: FAIL (Safari: FAIL)
  • /fs/FileSystemObserver.https.tentative.any.html [wpt.fyi]: ERROR (Safari: ERROR)
    • Creating a FileSystemObserver from a supported global succeeds: FAIL (Safari: FAIL)
    • Calling unobserve() without a corresponding observe() shouldn't throw: FAIL (Safari: FAIL)
    • unobserve() is idempotent: FAIL (Safari: FAIL)
    • Calling disconnect() without observing shouldn't throw: FAIL (Safari: FAIL)
    • disconnect() is idempotent: FAIL (Safari: FAIL)
    • observe() fails when file does not exist: FAIL (Safari: FAIL)
    • observe() fails when directory does not exist: FAIL (Safari: FAIL)
    • Creating a file through FileSystemDirectoryHandle.getFileHandle is reported as an "appeared" event if in scope: FAIL (Safari: FAIL)
    • Removing a file through FileSystemFileHandle.remove is reported as an "disappeared" event if in scope: NOTRUN (Safari: NOTRUN)
    • Events outside the watch scope are not sent to the observer's callback: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "moved" event if destination and source are in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is not reported if destination and source are not in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "appeared" event if only destination is in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "disappeared" event if only source is in scope: NOTRUN (Safari: NOTRUN)
    • Observations stop after disconnect(): NOTRUN (Safari: NOTRUN)
    • Observations stop for all observed handles after disconnect(): NOTRUN (Safari: NOTRUN)
  • /fs/FileSystemObserver.https.tentative.any.worker.html [wpt.fyi]: ERROR (Safari: ERROR)
    • Creating a FileSystemObserver from a supported global succeeds: FAIL (Safari: FAIL)
    • Calling unobserve() without a corresponding observe() shouldn't throw: FAIL (Safari: FAIL)
    • unobserve() is idempotent: FAIL (Safari: FAIL)
    • Calling disconnect() without observing shouldn't throw: FAIL (Safari: FAIL)
    • disconnect() is idempotent: FAIL (Safari: FAIL)
    • observe() fails when file does not exist: FAIL (Safari: FAIL)
    • observe() fails when directory does not exist: FAIL (Safari: FAIL)
    • Creating a file through FileSystemDirectoryHandle.getFileHandle is reported as an "appeared" event if in scope: FAIL (Safari: FAIL)
    • Removing a file through FileSystemFileHandle.remove is reported as an "disappeared" event if in scope: NOTRUN (Safari: NOTRUN)
    • Events outside the watch scope are not sent to the observer's callback: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "moved" event if destination and source are in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is not reported if destination and source are not in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "appeared" event if only destination is in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "disappeared" event if only source is in scope: NOTRUN (Safari: NOTRUN)
    • Observations stop after disconnect(): NOTRUN (Safari: NOTRUN)
    • Observations stop for all observed handles after disconnect(): NOTRUN (Safari: NOTRUN)
  • /fs/FileSystemObserver.https.tentative.any.sharedworker.html [wpt.fyi]: ERROR (Safari: ERROR)
    • Creating a FileSystemObserver from a supported global succeeds: FAIL (Safari: FAIL)
    • Calling unobserve() without a corresponding observe() shouldn't throw: FAIL (Safari: FAIL)
    • unobserve() is idempotent: FAIL (Safari: FAIL)
    • Calling disconnect() without observing shouldn't throw: FAIL (Safari: FAIL)
    • disconnect() is idempotent: FAIL (Safari: FAIL)
    • observe() fails when file does not exist: FAIL (Safari: FAIL)
    • observe() fails when directory does not exist: FAIL (Safari: FAIL)
    • Creating a file through FileSystemDirectoryHandle.getFileHandle is reported as an "appeared" event if in scope: FAIL (Safari: FAIL)
    • Removing a file through FileSystemFileHandle.remove is reported as an "disappeared" event if in scope: NOTRUN (Safari: NOTRUN)
    • Events outside the watch scope are not sent to the observer's callback: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "moved" event if destination and source are in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is not reported if destination and source are not in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "appeared" event if only destination is in scope: NOTRUN (Safari: NOTRUN)
    • Moving a file through FileSystemFileHandle.move is reported as a "disappeared" event if only source is in scope: NOTRUN (Safari: NOTRUN)
    • Observations stop after disconnect(): NOTRUN (Safari: NOTRUN)
    • Observations stop for all observed handles after disconnect(): NOTRUN (Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac48ea4412ad [wpt PR 49200] - FSO: Omit changedHandle for "disappear", "error", and "unknown" events, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ac48ea4412ad

Status: NEW → RESOLVED
Closed: 24 days ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.