1931623 - Legacy Telemetry event `security.fissionPrincipals#contentParent` is not being mirrored to because of incorrect extra key naming

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten]

In https://phabricator.services.mozilla.com/D221487 we used principal_type for the name of the extra when we needed to use principalType to exactly match the extra key of the Legacy Telemetry definition in Events.yaml.

Discovered while writing the test for bug 1924488.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1931623 - Fix event extra naming for security.fission_principals r?florian

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1918226

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcfb37e3c6ab
Fix event extra naming for security.fission_principals r=florian

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/fcfb37e3c6ab

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:chutten, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Chris H-C :chutten]

Attachment: Bug 1931623 - Fix event extra naming for security.fission_principals r?florian

Original Revision: https://phabricator.services.mozilla.com/D229206

Comment 7

[Chris H-C :chutten]

May need to wait a day to see the data. These events are rare (3-300 received per day from nightly across all builds) and the fix hasn't had time to have decent uptake. I can request uplift, but I won't be able to say it's verified in Nightly if so.

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: Low
• Explanation of risk level: A small rename of instrumentation
• String changes made/needed: n/a
• Is Android affected?: no

Comment 9

[Donal Meehan [:dmeehan]]

:chutten Fx133 is now in RC, I can change your uplift request to release though wanted to check with you first.
Given that, is this still something you would like to include as a potential release ride along?

Comment 10

[Chris H-C :chutten]

Without positive confirmation from the data, I'm hesitant to ask for this to enter RC. I mean, it's the lowest risk change and it'd be nice to have, but I don't want to risk RC stability.

Comment 11

[Donal Meehan [:dmeehan]]

(In reply to Chris H-C :chutten from comment #10)

Without positive confirmation from the data, I'm hesitant to ask for this to enter RC. I mean, it's the lowest risk change and it'd be nice to have, but I don't want to risk RC stability.

I can change it to release and keep it on the radar for a potential dot release ride along.
That will give it time in nightly/beta before hitting release.

Comment 12

[Chris H-C :chutten]

Verified in Nightly: Yes

We've successfully received our first event that suggests the patch fixes the problem.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/d899110425ca