1931631 - C++ indexer should treat constructor member initializer list field uses as having a contextsym of the constructor

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

Currently field uses that are part of a constructor member initializer list end up having a context/contextsym of the constructor declaration because getContext(<the-constructor-decl>) is used which explicitly skips over the constructor decl. This means that field initializations either end up attributed as uses by the class if the constructor was defined inside the class definition or top-level uses if the constructor was defined outside of the class. This is easily addressed by making sure we use the constructor as the context decl.

I noticed this when the uses diagram for a field did not include the constructor. example field search.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: mozsearch PR

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Bug 1931631 - C++ indexer should treat constructor member initializer list field uses as having a contextsym of the constructor

This is propagating the upstream
https://github.com/mozsearch/mozsearch/pull/835 which was reviewed by
:arai.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00a3e992ba4f
C++ indexer should treat constructor member initializer list field uses as having a contextsym of the constructor

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/00a3e992ba4f