1931736 - Add missing braces around if/loop statement in layout code

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Description

[Jonathan Watt [:jwatt]]

I've noticed fixups to add curly braces around if and loop statements with only a single line body making it into patches fairly regularly. I think it's generally fine to make these incidental unrelated fixes when touching a file. However, in some of the larger patches that have been going by recently the unrelated clutter it adds makes reviews harder to get through. We should probably just make these changes as a separate bunch of patches.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/base/. r=emilio

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/build/. r=emilio

Depends on D229245

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/forms/. r=emilio

Depends on D229246

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/generic/. r=emilio

Depends on D229247

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/inspector/. r=emilio

Depends on D229248

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/mathml/. r=emilio

Depends on D229249

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/painting/. r=emilio

Depends on D229250

Comment 8

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/printing/. r=emilio

Depends on D229251

Comment 9

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/style/. r=emilio

Depends on D229252

Comment 10

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/svg/. r=emilio

Depends on D229253

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/tables/. r=emilio

Depends on D229254

Comment 12

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/tools/. r=emilio

Depends on D229255

Comment 13

[Jonathan Watt [:jwatt]]

Attachment: Bug 1931736. Add missing braces around if/loop statements in layout/xul/. r=emilio

Depends on D229256

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3d0dda7f5e5
Add missing braces around if/loop statements in layout/base/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/954b23281db3
Add missing braces around if/loop statements in layout/build/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a4ba6d0c40ba
Add missing braces around if/loop statements in layout/forms/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/e370d5239d9a
Add missing braces around if/loop statements in layout/generic/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/8b368a75e8ec
Add missing braces around if/loop statements in layout/inspector/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/01adb9624962
Add missing braces around if/loop statements in layout/mathml/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a149f4ddd04b
Add missing braces around if/loop statements in layout/painting/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/794337a23a49
Add missing braces around if/loop statements in layout/printing/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/7398a7ce398e
Add missing braces around if/loop statements in layout/style/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/74ecd41de416
Add missing braces around if/loop statements in layout/svg/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/2e235c89ff11
Add missing braces around if/loop statements in layout/tables/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/57b93c89114b
Add missing braces around if/loop statements in layout/tools/. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/95fa1b7f27f1
Add missing braces around if/loop statements in layout/xul/. r=layout-reviewers,emilio

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a3d0dda7f5e5
https://hg.mozilla.org/mozilla-central/rev/954b23281db3
https://hg.mozilla.org/mozilla-central/rev/a4ba6d0c40ba
https://hg.mozilla.org/mozilla-central/rev/e370d5239d9a
https://hg.mozilla.org/mozilla-central/rev/8b368a75e8ec
https://hg.mozilla.org/mozilla-central/rev/01adb9624962
https://hg.mozilla.org/mozilla-central/rev/a149f4ddd04b
https://hg.mozilla.org/mozilla-central/rev/794337a23a49
https://hg.mozilla.org/mozilla-central/rev/7398a7ce398e
https://hg.mozilla.org/mozilla-central/rev/74ecd41de416
https://hg.mozilla.org/mozilla-central/rev/2e235c89ff11
https://hg.mozilla.org/mozilla-central/rev/57b93c89114b
https://hg.mozilla.org/mozilla-central/rev/95fa1b7f27f1