1931823 - [win10] The Bookmark star icon is not visible on hover with High Contrast if the page is bookmarked

Status: NEW

(Firefox :: Theme, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: contrast_00.gif

Found in

• 134.0a1 (2024-11-17)

Affected versions

• 134.0a1 (2024-11-17)
• 133.0b9
• 132.0.1
• 128.4.0esr

Tested platforms

• Affected platforms: Windows 10
• Unaffected platforms: macOS 12, Ubuntu 24

Precognitions

• OS High contrast enabled (reproducible with all 4 options)
• Firefox System theme enabled

Steps to reproduce

1. Bookmark a random page and hover the bookmark button.

Expected result

• The star icon is visible.

Actual result

• The star icon is not visible.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fe7af5b078750f8394e5dbb4333a8c1471c9af66&tochange=6c6258954d92b34174ed0fb95bb92107a5c602ad

Additional notes

• Attached a screen recording.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: star_icon.gif

Sorry, I attached the wrong video in comment 0.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1890964, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Anna Yeddi [:ayeddi]]

Attachment: Figma reference for the Icon button on Win11 HCM Night Sky and Desert for default, hover, active, focus, disabled states with On/Off indications

The bug 1787934 covers the active (opened panel) state of the same control.

Expected set of colors for the hover state is (Figma reference, SSO required and in the comment image):

• Border of the button and the icon fill: SelectedItem
• Button background: SelectedItemText

When the page is not bookmarked, the SelectedItem is used only for the icon border/shape, but the fill is SelectedItemText.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1890964