1931937 - [wpt-sync] Sync PR 49232 - Implement new behavior for popovers contained within invokers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49232 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49232
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Implement new behavior for popovers contained within invokers

In this case:

\<button popovertarget=foo>Activate
  \<div popover id=foo>Clicking me shouldn't close me\</div>
\</button>

clicking the button properly activates the popover, however,
clicking on the popover itself after that should not close
the popover. It currently does because the popover click
bubbles to the \<button> and activates the invoker, which
toggles the popover closed.

This CL changes that behavior so that clicks on the popover
in the case above no longer re-invoke the popover.

Spec PR:
https://github.com/whatwg/html/pull/10770

Bug: 379241451
Change-Id: Iab67127c46a97a081a7818bfd917864729bf8b5c
Reviewed-on: https://chromium-review.googlesource.com/6026982
WPT-Export-Revision: 004801ef2e097df93899c91c84fdd8702f7c20e4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fcedc6660d90ee63cb38f42898b73e5a238d5d6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bb227f42ceb0ff3418f928e4412cdb1421cffd7

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 2

Chrome

OK : 1
PASS: 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/popovers/popover-nested-in-button.tentative.html [wpt.fyi]
  • clicking a popover nested inside a button should not re-invoke the popover: FAIL (Chrome: FAIL)
  • invoker inside popover still works, even with weird nesting: FAIL (Chrome: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bc5ed8ce26d
[wpt PR 49232] - Implement new behavior for popovers contained within invokers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0aa42f2f7af7
[wpt PR 49232] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ef5f6532921
[wpt PR 49232] - Implement new behavior for popovers contained within invokers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d7da10f2415b
[wpt PR 49232] - Update wpt metadata, a=testonly

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9ef5f6532921
https://hg.mozilla.org/mozilla-central/rev/d7da10f2415b