1932009 - [wpt-sync] Sync PR 49251 - [Gap Decorations]: Introduce ColumnRuleWidth on ComputedStyle

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49251 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49251
Details from upstream follow.

Sam Davis Omekara (from Dev Box) <[e-mail]> wrote:

[Gap Decorations]: Introduce ColumnRuleWidth on ComputedStyle

This CL introduces a new data structure to extend the ColumnRuleWidth
property for the gap decorations feature. Previously, the
column-rule-width property could hold only a single width value.
However, with the gap decorations feature, this property can now hold
multiple values. The CL utilizes the GapDataList template data
structure to store these values in the computed style object.
Additionally, sites that expect a single width value have been updated
to call GetLegacyValue(), which returns the single width.

The CL also updates the parsing logic to return nullptr when no values
are present, allowing the use of the default value.

The code is exercised through the gap-decorations-width-computed.html
test.

Bug: 357648037
Change-Id: I5a28f332c57b16f90d7647c4b601b6eb32f7bb6d

Reviewed-on: https://chromium-review.googlesource.com/5967393
WPT-Export-Revision: 29e612958736cc14f2eebc2742bf956b3a7f07b5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=de36046f5003d80303a7d8493dba783ef8e0c536

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 6

Chrome

OK : 1
PASS: 2
FAIL: 6

Safari

OK : 1
PASS: 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-gaps/tentative/parsing/gap-decorations-width-computed.html [wpt.fyi]
  • Property column-rule-width value '2px 4px 6px': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property column-rule-width value 'repeat(4, 2px)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property column-rule-width value 'repeat(auto, 10px)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property column-rule-width value 'repeat(calc(5 + 3), 10px)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property column-rule-width value 'repeat(5, 10px calc(10px + 0.5em))': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property column-rule-width value 'repeat(auto, min(5px, 10px)) repeat(5, 10px) calc(10px + 0.5em)': FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c58a9927b34
[wpt PR 49251] - [Gap Decorations]: Introduce ColumnRuleWidth on ComputedStyle, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e48c6e6ed430
[wpt PR 49251] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ae3fe1baada
[wpt PR 49251] - [Gap Decorations]: Introduce ColumnRuleWidth on ComputedStyle, a=testonly
https://hg.mozilla.org/integration/autoland/rev/fe692d6849c2
[wpt PR 49251] - Update wpt metadata, a=testonly

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1ae3fe1baada
https://hg.mozilla.org/mozilla-central/rev/fe692d6849c2