1932117 - The text from some of the Sidebar Microsurvey slides is missing on en-US locales

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Alexandru Bejenaru [:abejenaru], Ecosystem QA]

Attachment: 1.png

[Affected versions]:

• Firefox Nightly 134.0a1, BUILD ID: 20241118213357.

[Affected Platforms]:

• Windows 10.
• Ubuntu 22.04.
• macOS 14.7.

[Prerequisites]:

• The new Sidebar is enabled from the “Firefox Labs” screen (about:preferences#experimental).
• User is enrolled in the “134 Sidebar microsurvey” rollout on a new profile.
• Locale of the browser is en-US.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Click any of the tools displayed in the sidebar 4 times (by default, only “History” and “Tabs from other devices” are available).
3. Click any tool from the sidebar for the 5th time and trigger the microsurvey.
4. Progress through the microsurvey slides and observe the behavior.

[Expected result]:

• All the text from the microsurvey is displayed accordingly.

[Actual result]:

• The text for the answers from some of the microsurvey slides is missing.

[Regression window]:

• Last good revision: 4424e72e5872e8fdfa2cfba982240bace917fe72
• First bad revision: b25ce25984e4bcf89b8fa7bc38da7f34b58c35ca
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4424e72e5872e8fdfa2cfba982240bace917fe72&tochange=b25ce25984e4bcf89b8fa7bc38da7f34b58c35ca

[Additional Notes]:

• Messages such as “[fluent] Missing message in locale en-US: sidebar-callout-survey-very-dissatisfied” can be seen in the console logs.
• This issue is reproducible with the Right Position microsurvey as well.
• This issue is not reproducible with a fr locale for example.
• This issue is not reproducible using an older Firefox Nightly build.

Comment 1

[Alexandru Bejenaru [:abejenaru], Ecosystem QA]

Attachment: 3.png

Comment 2

[Kelly Cochrane [:kcochrane]]

This is simply due to string ids being updated in bug 1930771. Ania just needs to update the string IDs for the callouts in experimenter, and it's on her list to do so. I'll let Ania decide if/when she wants to close this out.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:abejenaru, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1930771

Comment 5

[Ania]

Alexandru, thank you!
I updated the strings in both surveys.
I was able to verify that the survey targeting users with the sidebar position on the right displays the new strings correctly. See screenshots attached.
I had troubles triggering the other survey, for users with the sidebar position on the left - not sure what the problem was, as I was trying on a brand new profile, without changing anything in the configuration with the exception of strings.
If you could reverify both, I'd be grateful!

Comment 6

[Ania]

Attachment: how satisfied.png

Comment 7

[Ania]

Attachment: sidebar features.png

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1930771

Comment 9

[Pascal Chevrel:pascalc]

Alexandru, could you verify the fix? thanks

Comment 10

[Alexandru Bejenaru [:abejenaru], Ecosystem QA]

Thank you for the ping, Pascal! Sorry for missing this one.

We have verified this issue using Firefox Beta 134.0b4 BUILD ID: 20241202091515, Firefox Nightly 135.0a1 BUILD ID: 20241204092616 on Windows 10 x64, macOS 14.7, Ubuntu 24.04 and we were unable to reproduce it anymore. All the text from the microsurvey is now being properly displayed. Verified with both left and right side microsurveys. As a result I'm closing this as Resolved > Verified Fixed, thank you!