1932179 - [wpt-sync] Sync PR 49267 - DOM: Flag-guard moveBefore()'s range and selection preservation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49267 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49267
Details from upstream follow.

Dominic Farolino <[e-mail]> wrote:

DOM: Flag-guard moveBefore()'s range and selection preservation

Per discussion in https://github.com/whatwg/dom/pull/1307, we've
decided to not ship range and selection preservation initially. Since
this was mostly implemented in Chromium, this CL flag-gaurds our
implementation of that preservation (so it does not ship along with
the rest of the API's side-effects) and updates the tests.

R=[e-mail]

Bug: 40150299
Change-Id: Ia4412d95859497593ac2e4d9e9b87dfc36240ef4
Reviewed-on: https://chromium-review.googlesource.com/6022661
WPT-Export-Revision: 5458985a7940fccfec459eaf1b51504b2886e5a9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bb9e16c459d2244f768f9503c62633e130649a7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
FAIL: 9

Chrome

OK : 2
FAIL: 9

Safari

OK : 2
FAIL: 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/nodes/moveBefore/tentative/live-range-updates.html [wpt.fyi]
  • moveBefore still results in range startContainer snapping up to parent when startContainer is moved: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore still causes range startContainer to snap up to parent, when startContainer ancestor is moved: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore still causes range endContainer to snap up to parent, when endContainer ancestor is moved: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/nodes/moveBefore/tentative/selection-preserve.html [wpt.fyi]
  • moveBefore should not reset selection with preceding text: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore resets selection that enters a subtree, when the whole selection is moved: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore anchor node moved up to expand selection and absorb nodes: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore move intersecting nodes out of a selection: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore focus node moved up to shrink selection and exclude nodes; focus node gets reset: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore selection is not preserved, especially when underlying range gets inverted: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/748dd806b6f0
[wpt PR 49267] - DOM: Flag-guard moveBefore()'s range and selection preservation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/fe8cc09d28f8
[wpt PR 49267] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/748dd806b6f0
https://hg.mozilla.org/mozilla-central/rev/fe8cc09d28f8