1932218 - Hard-coded content in browser_menu_tools_description_2

Status: RESOLVED DUPLICATE of bug 1931824

(Firefox for Android :: Toolbar, defect)

Description

[Francesco Lodolo [:flod]]

We have a string blocked in review, so I went searching for the code
https://github.com/mozilla-l10n/android-l10n/pull/834

https://hg.mozilla.org/mozilla-central/rev/9ec7b95d8b9c

While I'm not familiar with Android development, I think this is hard-coding spaces and commas to inject them in Reader View,%s Print, Share, Open app

if (reportSiteIssueLabel != null) {
    (" $reportSiteIssueLabel,")
} else {
    ""
},

This doesn't work, you should expose 2 separate strings without replacements.

Reader View, Report Site Issue, Print, Share, Open app
Reader View, Print, Share, Open app

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1929334

:giorga, since you are the author of the regressor, bug 1929334, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Iorga Gabriel]

I made a fix https://bugzilla.mozilla.org/show_bug.cgi?id=1931824