193222 - Update Mac Desktop Get Info string for Mozilla 1.3 final release

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[lpham]

Need to checkin to MOZILLA_1_3_BRANCH

Comment 1

[lpham]

Attachment: Update Mac Desktop Get Info String to Mozilla 1.3 final version

Need a=, sr= and r=

Comment 2

[J.J. Enser]

Loan, I reviewed your changes to Info.plist. (nsMacVersion.r is no longer part
of the build, but the changes are ok)

You also need to update the version string in following file:
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings

This is a file that overwrites some values of Info.plist for localization
purposes, but since the affected string ("Mozilla 1.3b, © 1998-2003 The Mozilla
Organization") shouldn't be localized, I will remove the corresponding key
(CFBundleGetInfoString) from that file on the trunk so we don't have to
duplicate this change in the future.
Come and see me if you have questions, but please submit a patch for 1.3 final.

Comment 3

[lpham]

JJ, I cannot submit a diff for binary file so I removed 1.3b to 1.3 inside 
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings

CFBundleGetInfoString = "Mozilla 1.3b, © 1998-2003 The Mozilla Organization";

to 

CFBundleGetInfoString = "Mozilla 1.3, © 1998-2003 The Mozilla Organization";

(Note: I'm using BBEdit to edit this file)

Let me know if it looks ok to you.  Thanks.

Comment 4

[lpham]

Add twalker to cc list because bugzilla #194082 needs to submit the patch to
change
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings
as well.

Comment 5

[J.J. Enser]

same comment as in 194082:

r=jj for the change to .../English.lproj/InfoPlist.strings

The reason why we cannot diff these .plist files is because they have a
unicode 2-byte header which makes cvs think it's a binary file. Bummer, but I
don't think there's anything we can do about it.

Comment 6

[lpham]

Checked all 3 files.

Comment 7

[Tracy Walker [:tracy]]

verified