Update Mac Desktop Get Info string for Mozilla 1.3 final release

VERIFIED FIXED in mozilla1.3final

Status

--
critical
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: lpham, Assigned: lpham)

Tracking

Other Branch
mozilla1.3final
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed1.3, URL)

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Need to checkin to MOZILLA_1_3_BRANCH
(Assignee)

Updated

16 years ago
Target Milestone: --- → mozilla1.3final
(Assignee)

Comment 1

16 years ago
Created attachment 115397 [details] [diff] [review]
Update Mac Desktop Get Info String to Mozilla 1.3 final version

Need a=, sr= and r=
(Assignee)

Updated

16 years ago
Attachment #115397 - Flags: superreview?(leaf)
Attachment #115397 - Flags: review?(jj)

Updated

16 years ago
Attachment #115397 - Flags: review?(jj) → review+

Comment 2

16 years ago
Loan, I reviewed your changes to Info.plist. (nsMacVersion.r is no longer part
of the build, but the changes are ok)

You also need to update the version string in following file:
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings

This is a file that overwrites some values of Info.plist for localization
purposes, but since the affected string ("Mozilla 1.3b, © 1998-2003 The Mozilla
Organization") shouldn't be localized, I will remove the corresponding key
(CFBundleGetInfoString) from that file on the trunk so we don't have to
duplicate this change in the future.
Come and see me if you have questions, but please submit a patch for 1.3 final.
(Assignee)

Comment 3

16 years ago
JJ, I cannot submit a diff for binary file so I removed 1.3b to 1.3 inside 
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings

CFBundleGetInfoString = "Mozilla 1.3b, © 1998-2003 The Mozilla Organization";

to 

CFBundleGetInfoString = "Mozilla 1.3, © 1998-2003 The Mozilla Organization";

(Note: I'm using BBEdit to edit this file)

Let me know if it looks ok to you.  Thanks.
(Assignee)

Comment 4

16 years ago
Add twalker to cc list because bugzilla #194082 needs to submit the patch to
change
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings
as well.
Status: NEW → ASSIGNED

Comment 5

16 years ago
same comment as in 194082:

r=jj for the change to .../English.lproj/InfoPlist.strings

The reason why we cannot diff these .plist files is because they have a
unicode 2-byte header which makes cvs think it's a binary file. Bummer, but I
don't think there's anything we can do about it.

Updated

16 years ago
Attachment #115397 - Flags: superreview?(leaf) → superreview+
(Assignee)

Comment 6

16 years ago
Checked all 3 files.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Updated

16 years ago
Whiteboard: fixed1.3

Comment 7

16 years ago
verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.