[wpt-sync] Sync PR 49270 - Fix test_not_animatable() when underlying value not supported.
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox135 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Attachments
(10 files)
Sync web-platform-tests PR 49270 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/49270
Details from upstream follow.
David Baron <dbaron@chromium.org> wrote:
Fix test_not_animatable() when underlying value not supported.
Currently test_not_animatable() produces an error outside of a test()
when the underlying value is not supported. This is a problem,
particularly if the error can vary between implementations (rather than
being a test authoring error) because then the resulting exception leads
to a harness error and causes differences in test counts between
implementations. This is undesirable in WPT and causes the current
weird state of
https://wpt.fyi/results/css/css-values/calc-size/animation/interpolate-size-interpolation.htmlThis effectively moves the problematic assertion inside the test() --
except that the problematic assertion was already there but it wasn't
working because it depended on the scope of the "underlying" variable,
which was incorrect. So this fixes the scope of "underlying" so that
the existing assertion of the same thing inside the test() works. This
helps test_not_animatable() tests produce the same test counts on both
supporting and non-supporting implementations.I left the test assertion that is catching test authoring error the way
it was since it isn't really a problem in this way.Bug: 346977015
Change-Id: I4b1a18c13cdfab4e2a8fa597ecfd22cd7e02a40fReviewed-on: https://chromium-review.googlesource.com/6033413
WPT-Export-Revision: e7878b01ef56b6cd2a3155b8fc4cb984c86cde25
Assignee | ||
Updated•15 days ago
|
Assignee | ||
Comment 1•15 days ago
|
||
Assignee | ||
Comment 2•15 days ago
|
||
Assignee | ||
Comment 3•14 days ago
|
||
Assignee | ||
Comment 4•14 days ago
|
||
Assignee | ||
Comment 5•13 days ago
|
||
Assignee | ||
Comment 6•13 days ago
|
||
Assignee | ||
Comment 7•8 days ago
|
||
Assignee | ||
Comment 8•8 days ago
|
||
Assignee | ||
Comment 9•8 days ago
|
||
Assignee | ||
Comment 10•7 days ago
|
||
Assignee | ||
Comment 11•7 days ago
|
||
Assignee | ||
Comment 12•7 days ago
|
||
Comment 13•7 days ago
|
||
Assignee | ||
Comment 14•7 days ago
|
||
Comment 15•7 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/759ccc80321f
https://hg.mozilla.org/mozilla-central/rev/8759a1d9e859
Description
•