1932327 - Add support for MOZ_GECKO_PROFILER to mozinfo.py

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Bug 1930215 will provide us with the ability to use profiler testing "utility" functions outside of the core profiler module, however we need to be careful not to try to run tests using these functions when we build firefox without the profiler enabled.

Within the core profiler module, this is not an issue, as we check for if CONFIG["MOZ_GECKO_PROFILER"]: within moz.build, but this test is not possible for tests outside the profiler, as they are enabled/disabled by skip-if statements within the [browser|chrome|xpcshell|...].toml file that configures them.

The features enabled/disabled within skip-if statements are defined in mozinfo.py, and we should extend this to reflect whether or not firefox has been built with the profiler enabled. Tests for this can then be written in test_mozinfo.py.

Comment 1

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Note, we may also want to teach the taskgraph to guess configuration information: https://searchfox.org/mozilla-central/source/taskcluster/gecko_taskgraph/util/chunking.py#47

Also, do we need to do anything here? https://searchfox.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#1554

Comment 2

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1932327 - Add geckoprofiler configuration option to mozinfo.py so we can skip tests if Firefox is built without the profiler r?#profiler-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bd17c729ffb
Add geckoprofiler configuration option to mozinfo.py so we can skip tests if Firefox is built without the profiler r=profiler-reviewers,canaltinova

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/6bd17c729ffb