1932545 - Update android nightly application-services version bump to new version 3303de12a04710164f7c80fb5e466fbf2560a20f from 2024-11-21 05:02:27

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 4 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

3303de12a04710164f7c80fb5e466fbf2560a20f by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/3303de12a04710164f7c80fb5e466fbf2560a20f
Authored: 2024-11-19 22:41:33 -0800
Committed: 2024-11-20 20:45:53 +0000

Bug 1931963 - Add UniFFI bindings for fetch_geonames() in suggest

I didn't expect to be adding bindings for this, and there might be better ways
to support the use case described in bug than exposing fetch_geonames() as is,
but this works for now at least, and we need a fix for Firefox 134. Desktop will
call this to validate cities and states returned by the Yelp ML model. Not only
to validate but also to do prefix matching, since we can get that for free.

I considered adding a new function that matches both cities and regions at once
so that desktop doesn't need to call into suggest twice and ideally so that we
run only one SQL query. But I don't really like the idea of having a completely
different code path for this. Or, it might be possible to rewrite the current
function so it works that way. But that ends up getting a little messy pretty
quickly. So for now I did the simplest thing.

I also considered making geonames a full-fledged SuggestionProvider and
Suggestion, but then we'd have to add more options to
SuggestionProviderConstraints to support the fetch_geonames() params, and
these aren't really standalone suggestions anyway.

Files Modified:

• components/suggest/src/benchmarks/geoname.rs
• components/suggest/src/geoname.rs
• components/suggest/src/lib.rs
• components/suggest/src/provider.rs
• components/suggest/src/store.rs

---

c84cc9fd1db2dcd1a8b3a87bb704001f538f8b05 by Ryan VanderMeulen <[e-mail]>

https://github.com/mozilla/application-services/commit/c84cc9fd1db2dcd1a8b3a87bb704001f538f8b05
Authored: 2024-11-20 13:21:42 -0500
Committed: 2024-11-20 19:02:55 +0000

Update Gradle to version 8.11.1

Files Modified:

• gradle/wrapper/gradle-wrapper.properties

---

aa234f5559f6a0ba04faf7d2872bb116726e9502 by Ryan VanderMeulen <[e-mail]>

https://github.com/mozilla/application-services/commit/aa234f5559f6a0ba04faf7d2872bb116726e9502
Authored: 2024-11-20 13:26:22 -0500
Committed: 2024-11-20 19:02:42 +0000

Update Android SDK Command-line Tools to version 16.0

Files Modified:

• taskcluster/docker/linux/Dockerfile

---

24f7ddd79669fe00dd9f9675007d8e8676da48ff by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/mozilla/application-services/commit/24f7ddd79669fe00dd9f9675007d8e8676da48ff
Authored: 2024-11-18 00:59:19 +0000
Committed: 2024-11-20 18:20:04 +0000

build(deps): bump deprecated from 1.2.14 to 1.2.15 in /tools

Bumps deprecated from 1.2.14 to 1.2.15.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: deprecated
  dependency-type: direct:production
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• tools/requirements.txt

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=7bd72544dc6c9cd39e4d444101f6852417dece51

Comment 2

[Update Bot]

Attachment: Bug 1932545 - Update android nightly application-services version bump to 3303de12a04710164f7c80fb5e466fbf2560a20f

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed396047fc4d
Update android nightly application-services version bump to 3303de12a04710164f7c80fb5e466fbf2560a20f r=pascalc

Comment 5

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• ui-test-apk-fenix-arm-debug - 4 of 4 failed on the same (retriggered) task (failed: DZfYroy-TD2xHIn5fz2dqg, daQJTU0oQb-XvFoa-dFenQ, WhXdujC1QCC7Fpc_y_QJtg, XSd9RACJReSb-IpBMdLgHA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 6

[Donal Meehan [:dmeehan]]

Failure is tracked under Bug 1932513 and is unrelated to this AS update

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ed396047fc4d