1932736 - Optimize all non-elliptical corners, not only uniform border radii

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1932736 - Optimize most non-elliptical corner clips, not just uniform radii. r=nical

I might be doing something dumb, please review carefully, but this seems
to work and should speed up some common clip kinds like rounding two
bottom corners, two top corners, or a single corner :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=58a375179e757521974452de7590ef7fa4a83f61\

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d93eeb01bb
Optimize all non-elliptical corner clips, not just uniform radii. r=nical

Comment 4

[amarc]

Backed out for causing wrench bustages @ rounded-rects.yam

• Backout link
• Push with failures
• Failure Log
• Failure line:

REFTEST TEST-UNEXPECTED-FAIL | reftests/aa/rounded-rects.yaml == reftests/aa/rounded-rects-ref.png | image comparison, max difference: 2, number of differing pixels: 113 | 109 differences > 0 and <= 1 (allowed 1); 4 num_differences > 1 and <= 255 (allowed 0);

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case that breaks with my patch as-is.

So... Wrench caught an interesting edge case where my patch regresses (my patch only rounds the top right corner, incorrectly).

We can't use the fast path if the corners are bigger than half-size of the box and the opposite corner doesn't have the same radius.

A bit trickier but not hard to deal with.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcaed8e428ad
Optimize most non-elliptical corner clips, not just uniform radii. r=nical

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bcaed8e428ad

Comment 8

[Florin Bilt]

(In reply to Serban Stanca [:SerbanS] from comment #7)

https://hg.mozilla.org/mozilla-central/rev/bcaed8e428ad

Perfherder has detected a browsertime performance change from push bcaed8e428ad1965e4a9156febe8c7a514f4d7c6.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
6%	amazon FirstVisualChange	macosx1015-64-shippable-qr	bytecode-cached cold fission webrender	486.38 -> 457.82	Before/After
5%	amazon ContentfulSpeedIndex	macosx1015-64-shippable-qr	bytecode-cached cold fission webrender	513.77 -> 485.75	Before/After
5%	amazon PerceptualSpeedIndex	macosx1015-64-shippable-qr	bytecode-cached cold fission webrender	516.84 -> 488.95	Before/After
5%	amazon SpeedIndex	macosx1015-64-shippable-qr	bytecode-cached cold fission webrender	548.64 -> 521.65	Before/After
4%	amazon ContentfulSpeedIndex	macosx1015-64-shippable-qr	bytecode-cached cold fission webrender	511.90 -> 489.82	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42906

For more information on performance sheriffing please see our FAQ.