1932859 - [Experiment] The Firefox menu is dismissed if clicking inside the "DEVICE_MIGRATION_FXA_CTA_EXP1" message

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: clicking inside the message.mp4

[Affected versions]:

• Firefox Release 133.0 (Build ID: 20241118181856)
• Firefox Nightly 134.0a1 (Build ID: 20241120171202)

[Affected Platforms]:

• Windows 10 x64
• macOS 15.0.1
• Ubuntu 24.04 x64

[Prerequisites]:

• Have following prefs set:
  • nimbus.debug = true
• Be enrolled in any of the treatment branches of the experiment. You can force enroll in the treatment-a branch by navigating to: about:studies?optin_slug=account-adoption-app-menu-experiment-firefox-release&optin_branch=treatment-a&optin_collection=nimbus-preview

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Click the "Open application menu button" button in order to open the Hamburger menu.
3. Click inside the message displayed.

[Expected result]:

• Nothing happens.

[Actual result]:

• The Hamburger menu is dismissed.

[Notes]:

• The issue is also reproducible for the PXI menu.
• Attached is a screen recording of the issue.

Comment 1

[Jason Prickett]

:mconley it looks like this is also something you'd like to take a look at

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'm of the opinion that this bug is valid, but doesn't block the messaging experiment that we aim to do. I'll go ahead and set this as a P3 for now.

Comment 3

[[e-mail]]

Agree it doesn't block the experiment. What does P3 mean in terms of time to fix? We will almost certainly roll this out, and it would be good to have this fixed before we do. Can it catch Firefox 135?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Yes, I think this should be straight-forward.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1932859 - Prevent auto-closing of the AppMenu / FxA panels when generically clicking the FxA menu message CTA. r?pdahiya!

The change in CustomizableUI is required because the routine wasn't designed to handle
custom elements with shadow roots. The routine's job is to walk up the ancestry of
the click event and determine if any of the parents have certain characteristics
that would indicate that the event should not close the panel, and without this
change it would bail out as soon as it hit the shadow root if the event's original
target was inside the custom element.

In this case, the element enclosing the fxa-menu-message is the "appMenu-fxa-menu-message"
toolbaritem with closemenu="none", which this modification now lets
CustomizableUI detect.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa3c500f251f
Prevent auto-closing of the AppMenu / FxA panels when generically clicking the FxA menu message CTA. r=pdahiya,omc-reviewers

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/aa3c500f251f

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 135.0a1 (Build ID: 20241210205259) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1.

• The menu is no longer dismissed if you click inside the message.