1932962 - Optimize CounterMetric construction when disabled

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P4)

Description

[Chris H-C :chutten]

Right now we have an optimized path using codegen_new for constructing CounterMetric instances in a way that's as small as possible in terms of binary size (bug 1866479).

With bug 1931277 it is very likely that Thunderbird will be mass-disabling these metrics. But codegen_new presumes that the metric is enabled.

This bug is about reducing binary size for default-disabled use-counter-style counter metrics. (Probably by writing codegen_disabled_new)

Note that we can't "just" make these all anonymous or disappear because Server Knobs could come in and re-enable them.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1932962 - Optimize the construction of simple disabled counter metrics r?TravisLong

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/135720192601
Optimize the construction of simple disabled counter metrics r=TravisLong

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/135720192601