1933114 - Add tests for tab group restoration

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P2)

Description

[Stephen Thompson [:sthompson]]

Add more (and more thorough) tests for restoring tab groups to the tab strip.

1. Saved tab groups
2. Closed/deleted tab groups in an open window
3. Closed/deleted tab groups in a closed window

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: Bug 1933114 - add tests for restoring tab groups r=dao,dwalker,jswinarton

Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceeaeae381df
tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9b2df3a57d63dab0ec52099a124257998fe77272

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_tab_groups_restore_closed_in_closed_window.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4436a8f5e82d
tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers

Comment 5

[amarc]

Backed out for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js

• Backout link
• Push with failures
• Failure Log
• Failure line:
• TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_tab_groups_restore_closed_in_closed_window.js | Test timed out -

Comment 6

[Stephen Thompson [:sthompson]]

Having issues with specifically ASan/TSan tests on Linux. Since the test issues are with a new test I'm adding, I'm going to skip the test for Linux ASan/TSan for now and address any issues in bug 1936093

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5ecd3645987
tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/3bbf60fbfed7506893d985e69b925f99a522b9f1

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_tab_groups_restore_closed_in_closed_window.js

Comment 9

[Stephen Thompson [:sthompson]]

I isolated the problem to ASan tests in all desktop platforms. The tests that I wrote load about:crashes in tabs under test, but ASan builds set MOZ_CRASHREPORTER_DISABLE=1 which has the effect of making about:crashes fail to load in the browser.

I changed all tab group-related tests (my new tests plus existing tests) that use about:crashes and had them load a different URI.

I can reliably get the tests to pass in an ASan build, so I'm hoping this will land successfully this time.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18b068949f6b
add tests for restoring tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers

Comment 12

[amarc]

https://hg.mozilla.org/mozilla-central/rev/18b068949f6b