1933266 - balrog: add support for alternative URLs in gmp blobs

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Andrew Osmond [:aosmond] (he/him)]

I would like balrog to deploy new elements in the <addons> XML for Widevine. Each <addon> element could have an arbitrary number of <mirror> elements as its children, with the URL attribute being an alternative location to download the same file as the URL attribute in the <addon> element.

The Firefox piece of this is being implemented in bug 1932482. Ideally we would deploy first to nightlytest to verify that builds with and without the patch work as expected prior to deployment on nightly/beta/release/ESR. This should be a backwards/forwards compatible configuration change, where the older clients simply ignore the new <mirror> elements, and the new clients use the mirror URLs when the primary is inaccessible.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Mirror URL augmented configuration for Widevine, v1

Could we deploy these changes to nightlytest as per the description above?

fileUrl continues to map to the URL attribute of the addon element
mirrorUrls maps to creation of a mirror element with the URL attribute set to the given URL in the array, which is the child of the relevant addon element

e.g. partial XML for Darwin_aarch64-gcc3:

<addon URL="https://edgedl.me.gvt1.com/edgedl/release2/chrome_component/dhuvyipbjqknanqk7f3zqnv4ku_4.10.2830.0/oimompecagnajdejgnnjijobebaeigek_4.10.2830.0_mac_arm64_lt3covpsgi3bctnfic74bafcxa.crx3">
  <mirror URL="https://www.google.com/dl/release2/chrome_component/dhuvyipbjqknanqk7f3zqnv4ku_4.10.2830.0/oimompecagnajdejgnnjijobebaeigek_4.10.2830.0_mac_arm64_lt3covpsgi3bctnfic74bafcxa.crx3"/>
</addon>

Comment 2

[Julien Cristau [:jcristau]]

Attachment: [mozilla-releng/balrog] Bug 1933266 - Add support for mirror URLs for GMP plugins. (#3251)

Comment 3

[Julien Cristau [:jcristau]]

Attachment: [mozilla-releng/balrog] Bug 1933266 - Update domain allowlist for Widevine (#3252)

Comment 4

[[e-mail] (:bhearsum)]

This is live on stage now. URLs such as https://stage.balrog.nonprod.cloudops.mozgcp.net/update/3/GMP/130.0/20200518093924/WINNT_x86_64-msvc-x64/en-US/nightly/Windows_NT%2010.0.0.0.18363.1016%20(x64)/default/default1/update.xml are received mirrorUrls for Widevine (but notably, not Widevine-L1).

The new code will hit prod on Tuesday, and we can then consider making changes to the live Widevine data there.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

I confirmed that the current nightly (with my patch from bug 1932482) downloads from edgedl.me.gvt1.com as expected if the Widevine plugin isn't installed. If I retry, but blocking access to edgedl.me.gvt1.com via the hosts file, it attempts edgedl.me.gvt1.com, fails, and then tries www.google.com. I will do more smoke testing with and without my uplift patches on the various release channels and report back here.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

I forgot to report back that I tested on all channels (nightly, beta, 133/128esr/115esr +/- my patch) and it works with the new/old balrog.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

I think we can closed this as fixed.