1933328 - WebGPU: Handle 2024-08 renames in image copy APIs

Status: ASSIGNED

(Core :: Graphics: WebGPU, task, P2)

Description

[Erich Gubler [:ErichDonGubler]]

Motivating change upstream: gpuweb#4838

Comment 1

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1933328 - refactor(webgpu): handle 2024-08 image copy renames from upstream IDL r=#webgpu-reviewers

Driven by gpuweb#4838.

The vast majority of this script was implemented with a Nushell script,
using the nu binary and the wonderful fastmod tool

# Copy-pasted from the OP in [`gpuweb`#4838](https://github.com/gpuweb/gpuweb/pull/4838).
let renames_table = '
Type 	Old 	New 	Used in
dict 	GPUImageDataLayout 	GPUTexelCopyBufferLayout 	"writeTexture,
parent type of ↙"
dict 	GPUImageCopyBuffer 	"GPUTexelCopyBufferInfo
extends ↑" 	T2B, B2T
dict 	GPUImageCopyTexture 	GPUTexelCopyTextureInfo 	T2B, B2T, T2T, writeTexture
dict 	GPUImageCopyTextureTagged 	"GPUCopyExternalImageDestInfo
extends ↑" 	copyExternalImageToTexture
dict 	GPUImageCopyExternalImage 	GPUCopyExternalImageSourceInfo 	copyExternalImageToTexture
union 	GPUImageCopyExternalImageSource 	GPUCopyExternalImageSource 	member of ↖
'

let renames_table = $renames_table
  | from tsv
  | select 'Old ' 'New '
  | rename old new
  | update new { $in | lines | get 0 } # only the first line has the renamed symbol identifier
  | update new { str trim }
  | update old { str trim }
  | sort-by old | reverse # Replace most specific symbol names first (some have the same "word segments" but with fewer segments)

# Rename image APIs.
let rename_paths = [
  ...("dom/webgpu/*.{cpp,h}" | str expand)
  "dom/webidl/WebGPU.webidl"
] | each { glob $in } | flatten

for entry in $renames_table {
  print $'replacing ($entry.old | to nuon) with ($entry.new | to nuon)'
  fastmod --accept-all $'\b($entry.old)' $entry.new ...$rename_paths
}

Comment 2

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1933328 - refactor(webgpu): handle 2024-08 image copy renames in WGPU upstream r=#webgpu-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08a24ec85517
refactor(webgpu): handle 2024-08 image copy renames from upstream IDL r=webgpu-reviewers,webidl,teoxoy,emilio

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccdf879264e5
Backed out changeset 08a24ec85517 for causing build bustages @ WebGpu. CLOSED TREE

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out changeset 08a24ec85517 for causing build bustages

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=08a24ec855174eaf82c2da1069d7778f2edc70fc&selectedTaskRun=GVdSZg-uTDOPbUGJzYNWXg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=484343077&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ccdf879264e5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/155ce9b483bd
refactor(webgpu): handle 2024-08 image copy renames from upstream IDL r=webgpu-reviewers,webidl,teoxoy,emilio

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/155ce9b483bd