Closed
Bug 193347
Opened 23 years ago
Closed 23 years ago
Remove autocomplete data collection for 1.3
Categories
(SeaMonkey :: Autocomplete, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tor, Assigned: nisheeth_mozilla)
Details
(Whiteboard: fixed1.3)
Attachments
(1 file)
|
51.11 KB,
patch
|
alecf
:
review+
dbaron
:
approval1.3+
|
Details | Diff | Splinter Review |
The data collection added for bug 182366 should be removed for 1.3 - see
comment 54 of referenced bug.
| Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
| Assignee | ||
Comment 1•23 years ago
|
||
This patch backs out the checkin that happened for 1.3 beta (attachment
111259 [details] [diff] [review]). Both the data collection code and the learning code is removed by
this patch so that 1.3 final doesn't bloat by 20K. These code pieces will go
into the codebase in a more well factored way later as time permits.
| Assignee | ||
Comment 2•23 years ago
|
||
Comment on attachment 114952 [details] [diff] [review]
Patch that backs out attachment 111259 [details] [diff] [review]
Alec, as promised, this patch backs out the autocomplete patch (attachment
111259 [details] [diff] [review]).
Heikki, please super review.
Thanks!
Attachment #114952 -
Flags: superreview?(heikki)
Attachment #114952 -
Flags: review?(alecf)
Comment 3•23 years ago
|
||
Comment on attachment 114952 [details] [diff] [review]
Patch that backs out attachment 111259 [details] [diff] [review]
excellent, thanks nisheeth. r/sr=alecf
Attachment #114952 -
Flags: review?(alecf) → review+
| Assignee | ||
Comment 4•23 years ago
|
||
Comment on attachment 114952 [details] [diff] [review]
Patch that backs out attachment 111259 [details] [diff] [review]
Please give me approval to back out the learning and data collection code
checked into 1.3 beta for the autocomplete project.
I have an r/sr from alecf and have run the precheckin tests on my debug build.
Attachment #114952 -
Flags: approval1.3?
Attachment #114952 -
Flags: approval1.3? → approval1.3+
| Assignee | ||
Comment 5•23 years ago
|
||
Fix checked in on trunk...
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•23 years ago
|
Whiteboard: fixed1.3
Updated•23 years ago
|
Attachment #114952 -
Flags: superreview?(heikki)
Updated•21 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•