Closed Bug 1933489 Opened 14 days ago Closed 11 days ago

[wpt-sync] Sync PR 49375 - [text-box-trim] Retire text-box-edge propagation restriction

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox135 fixed)

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49375 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49375
Details from upstream follow.

Lingqi Chi <lingqi@chromium.org> wrote:

[text-box-trim] Retire text-box-edge propagation restriction

We added a restriction that the effective text-box-edge can be
propagated to its child only if the same node defines a non-initial
text-box-trim value when text-box-edge is not inherited.
But now the specification is updated[1] which marks text-box-edge as
inherited, and we no longer need this restriction.

This CL also removes
text-box-trim/text-box-trim-ignore-nested-text-box-edge.html
from the web-test. This test was replaces by
text-box-trim-not-ignore-nested-text-box-edge.html (each test
disagrees with the other) since [2], but for some reasons still stays
at the wpt codebase.

A follow-up will retire the EffectiveTextBoxEdge field.

[1] https://github.com/w3c/csswg-drafts/issues/10904
[2] https://github.com/web-platform-tests/wpt/commit/288ee9d3430ff09a227f1c96b3cbb25170ab1af4

Bug: 367766472, 374787320, 40254880
Change-Id: I789136ef54fa2d0c8b7a97b08caf1217512d10c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038647
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388218}

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9fea7f5a6e61 [wpt PR 49375] - [text-box-trim] Retire text-box-edge propagation restriction, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 11 days ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.