1933562 - Defer url classification action until socket thread

Status: ASSIGNED

(Core :: Networking, enhancement, P2)

Description

[edgul]

Placeholder

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: autotarray

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: cache markers

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: async classifier

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: cookieBehavior

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: add_pref

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: fixes

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: move cookie setting to lambda

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 1933562: option a

Comment 9

[Andrew Creskey [:acreskey]]

This patch is showing possible improvements of ~50ms on two devices in the Fenix newssite applink tests
https://perf.compare/compare-results?baseRev=7a9453665580261402920c820181ce981133f573&newRev=278b12a45e704df43cd988cdc72738bc7351e0d6&baseRepo=try&newRepo=try&framework=15

Note: we will have to re-test as a handful of the results are not valid due to bug 1979663

Comment 10

[Andrew Creskey [:acreskey]]

While this approach improves performance (specifically applink startup), Randell discovered significant technical complexity around cookies and other areas.
He proposed that a simpler solution may deliver most of the results: cache the results of url classification so that we only pay the price for the first url, captured in bug 1984478

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1933562: Add Glean telemetry for channel classification duration and dispatch time r=#necko-reviewers!

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1933562: Classifier result cache infrastructure (LRU cache, key/value, prefs) r=#necko-reviewers!,timhuang!

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1933562: extend cache for full classification results (key, entry, feature getters) r=#necko-reviewers!,timhuang!

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1933562: Integrate classifier result cache into CheckChannel (lookup, insert, invalidation) r=#necko-reviewers!,timhuang!

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1933562: cache full classification results and replay match hits on main thread r=#necko-reviewers!,timhuang!

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1933562: Add xpcshell tests for classifier result cache r=#necko-reviewers!

Comment 17

[BugBot [:suhaib / :marco]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D299564	Bug 1933562: cache full classification results and replay match hits on main thread r=#necko-reviewers!,timhuang!	jesup	timhuang: Back Jul 23, 2026

:jesup, could you please find another reviewer?

For more information, please visit BugBot documentation.