1933627 - [wpt-sync] Sync PR 49388 - fixes background-size tests for two values serialization

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49388 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49388
Details from upstream follow.

Karl Dubost <[e-mail]> wrote:

fixes background-size tests for two values serialization

This is fixing some WPT tests related to background-size results being serialized as two values, which is the new behavior of WebKit.
Some tests currently contradict themselves on WPT.
http://wpt.live/css/css-backgrounds/background-size-001.html
https://wpt.live/css/css-backgrounds/parsing/background-size-computed.html

So this PR makes it uniform and changes the expectation files.

This is dependent on a resolution from the CSS WG about the two values system. https://github.com/w3c/csswg-drafts/issues/7802

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6ce5251bc3846e8767cf542338f1e8969c74d37

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 20 subtests

Status Summary

Firefox

OK : 2
PASS: 18
FAIL: 10

Chrome

OK : 2
PASS: 18
FAIL: 10

Safari

OK : 2
PASS: 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-backgrounds/background-332.html [wpt.fyi]
  • background_specified_size: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-backgrounds/background-size-001.html [wpt.fyi]
  • background-size_length_zero: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_length_negative_zero: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_length_positive_zero: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_length_normal: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_percentage_min: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_percentage_normal: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_percentage_max: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_length_auto: FAIL (Chrome: FAIL, Safari: PASS)
  • background-size_percentage_auto: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42a224db37fb
[wpt PR 49388] - fixes background-size tests for two values serialization, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7b604fb97266
[wpt PR 49388] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/42a224db37fb
https://hg.mozilla.org/mozilla-central/rev/7b604fb97266