1933976 - [wpt-sync] Sync PR 49421 - Add unidirectional codec test support in WPT using H264.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49421 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49421
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Add unidirectional codec test support in WPT using H264.

According to PR[1], setCodecPreferences() should accept any codec that
is either in in RTCRtpSender.getCapabilities() or
RTCRtpReceiver.getCapabilities(); the actual filtering happens when the
SDP is generated based on the transceiver direction.

This makes it possible for a sendonly transceiver to offer a sendonly
codec and for a recvonly transceiver to offer a recvonly codec, as
opposed to forcing that all codecs must be receive-capable at
createOffer() time which is the old and currently implemented behavior,
hence the failing test. (In the old model, pc1 would be forced to not
have any preferences and pc2 be forced to call setCodecPreferences()
before createAnswer() on behalf of pc1 in case that pc1 is sendonly.)

Due to the limitation that on a local page both pc1 and pc2 have the
same capabilities, the remote SDP is modified to make pc1 think that
pc2 supports the codec being negotiated in the other direction.

Because getCapabilities() is device-specific, we skip the tests (using
[PRECONDITION_FAILED]) if the necessary capabilities (= unidirectional
H264) is not supported but the tests work e.g. on MacBook M1 Pro.

[1] https://github.com/w3c/webrtc-pc/pull/3018

Bug: chromium:379551577
Change-Id: I4e1ce5371db66de83d42cbd2ba2eca5d703661d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054227
Reviewed-by: Harald Alvestrand \<[e-mail]>
Commit-Queue: Henrik Boström \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1389353}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=335b58c1b34018e17fcd0095f3ac68e8faf82650

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PRECONDITION_FAILED: 2

Chrome

OK : 1
PASS : 1
PRECONDITION_FAILED: 1

Safari

OK : 1
PRECONDITION_FAILED: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/protocol/h264-unidirectional-codec-offer.https.html [wpt.fyi]
  • Offer to receive a recvonly H264 codec: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
  • Offer to send a sendonly H264 codec: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PRECONDITION_FAILED)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71f23cc2779b
[wpt PR 49421] - Add unidirectional codec test support in WPT using H264., a=testonly
https://hg.mozilla.org/integration/autoland/rev/40e75b488f17
[wpt PR 49421] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/71f23cc2779b
https://hg.mozilla.org/mozilla-central/rev/40e75b488f17