Closed Bug 1933989 Opened 3 months ago Closed 3 months ago

Tab Groups from the Horizontal Tab strip cannot be expanded/collapsed with a single click when slightly moving the mouse

Categories

(Firefox :: Tabbed Browser, defect, P1)

Desktop
Windows
defect
Points:
1

Tracking

()

VERIFIED FIXED
135 Branch
Tracking Status
firefox-esr128 --- disabled
firefox133 --- disabled
firefox134 --- disabled
firefox135 --- verified

People

(Reporter: rdoghi, Assigned: dao)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-tabgrps-tabbrowser])

Attachments

(2 files)

Attached video SingleClick.mp4

Found in

  • 135.0a1 (2024-11-28)

Affected versions

  • 135.0a1 (2024-11-28)
  • 134.0b2

Preconditions
Set browser.tabs.groups.enabled true
Have the Horizontal Tab strip enabled.

Affected platforms

  • Windows

Steps to reproduce

  1. Have a Few Tabs opened.
  2. Create a New Tab Group.
  3. Expand/Collapse any Tab group with a single click.

Expected result

  • Each Tab Group should Expand/Collapse using a single click.

Actual result

  • Tab groups for the Horizontal Tab bar only expand or collapse with a double click.
    Tab Groups from a Vertical Tab bar expand and collapse with a single click.

Regression range
Not a Regression.

Blocks: 1907099
Points: --- → 1
Priority: -- → P1
Whiteboard: [fidefe-tabgrps-tabbrowser]
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

This issue only seems to happen on Windows machines.

OS: Unspecified → Windows
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afa37cda8c97 Disabled window dragging on group labels so clicks are registered as clicks even when slightly moving the mouse. r=desktop-theme-reviewers,emilio
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Summary: Tab Groups from the Horizontal Tab strip cannot be expanded/collapsed with a single click → Tab Groups from the Horizontal Tab strip cannot be expanded/collapsed with a single click when slightly moving the mouse

This issue is Verified as fixed in our latest Nightly build 135.0a1 (2024-11-29).

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)

Updating the main status flag.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: