Open Bug 1934018 Opened 1 year ago Updated 1 year ago

[Automated review] Spurious Lint Warning for Files Untouched by Review

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect

Tracking

(Not tracked)

People

(Reporter: dshin, Unassigned)

Details

Phabricator URL: https://phabricator.services.mozilla.com/D230531

This is a small review that touches a single rust file + adds WPT testcase, but it seems to have generated numerous lint warnings about other files.

Thank you for the report.

The base revision is https://hg.mozilla.org/mozilla-central/rev/671bec590e6fb066200fc1b6942404da8d823b3c
Its rustfmt task contains these messages and they should be ignored.

From the logs:
Nov 28 07:22:46 34.71.146.77 code-review/production/bot 2024-11-28 15:22:46 debug.py: [info ] Issue publishable issue=source-test-mozlint-rustfmt issue source-test-mozlint-rustfmt@warning gfx/webrender_bindings/src/moz2d_renderer.rs line 10
logged here.

The logging statement to check for existing issues is logged 6 minutes later for that base revision but it's unknown if it's for that Phabricator revision.

Bastien, do you have an idea what started this today?

Flags: needinfo?(abadie)

There may be a bug in the before/after comparison in production now that the DB has far less issues than before the comparison.

Currently that feature is needed to get local clone, but with this patch we can disable before/after AND keep the local clone that just got activated.

:aryx Could you review this patch and run it on testing, then if it goes well, just push to prod: it should remove these extra warnings as only in-patch issues would be reported

Flags: needinfo?(abadie) → needinfo?(aryx.bugmail)

Thank you. Change has been pushed to testing and production - without tagging a release for now. I was not able to test because Phabricator's development instance rejects my bugzilla-dev credentials.

Flags: needinfo?(aryx.bugmail)

The issue was still observable around 23:00 UTC. I have requested the caching to be disabled, bhearsum merged the change.

It's due to the before/after config still present in the prod TC secret.

I removed the setting this morning, it should be OK to use cache without before/after now

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(bpostelnicu)
Severity: -- → S3
Flags: needinfo?(bpostelnicu)
You need to log in before you can comment on or make changes to this bug.