1934112 - Native Windows 10 title bar no longer white in Private Browsing tabs

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Edoardo Lolletti]

Attachment: Immagine.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

On windows 10 LTSC 2019, with no dark theme enabled, have windows use the native Windows title bar and open a new private window

Actual results:

The private window tab is opened, but the system title bar is now black instead of white

Expected results:

The system title bar should be white as it was until firefox 132, I tried to look for mentions of this change and for options to disable it, but couldn't find anything

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey emilio, are you aware of a behaviour change here? Is this an intentional change where the native titlebar will inherit the dark/light theme of the window?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Yes, this was fixed in bug 1923334 and matches the macOS and Linux behavior.

Comment 4

[Edoardo Lolletti]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Yes, this was fixed in bug 1923334 and matches the macOS and Linux behavior.

Is it possible to gave the option to go back to the old behaviour? And I'm not really sure if this is actually the "current behavior" on Linux, as there if you tell Firefox to use the native title bar, it will use it and not attempt to change its windows decorations.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

(In reply to Edoardo Lolletti from comment #4)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Yes, this was fixed in bug 1923334 and matches the macOS and Linux behavior.

Is it possible to gave the option to go back to the old behaviour?

Curious, why? Not right now, and I'd rather not add it:

• Before that change, if you had a dark theme, the old behavior was to have a dark titlebar already. It didn't work on private windows mostly by chance.
• For things like Windows 11 Mica and such, where we want to paint on top of the native backdrop, we do need the titlebar to match our color scheme on all windows.

So restoring the previous behavior would be rather odd. I guess having an option for making the titlebar match whatever system color scheme you have (only when using the native titlebar rather than the custom one) is feasible, but it is still a rather special case...

And I'm not really sure if this is actually the "current behavior" on Linux, as there if you tell Firefox to use the native title bar, it will use it and not attempt to change its windows decorations.

Fair, if you use server-side-decorations on Linux, then those are indeed out of our control.

Comment 6

[Edoardo Lolletti]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

(In reply to Edoardo Lolletti from comment #4)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Yes, this was fixed in bug 1923334 and matches the macOS and Linux behavior.

Is it possible to gave the option to go back to the old behaviour?

Curious, why? Not right now, and I'd rather not add it:
Simply because if I have Firefox set to use the native system title bar, I expect it not to change it and respect my current system settings (like with ssd on Linux), and not override the native window controls automatically.
Also this is mostly because of the white/dark theme used for private windows, rather for other themes in general, having the private windows be a different color is helpful to distinguish the various instances, but I don't like them having the title bar be of a different color, since having a random window that has a dark title bar while everything else has it white is out of place

So restoring the previous behavior would be rather odd. I guess having an option for making the titlebar match whatever system color scheme you have (only when using the native titlebar rather than the custom one) is feasible, but it is still a rather special case...

Well, having it as an option, even as an about:configs flag would be fine, didn't really expect for it to be entirely reverted

Comment 7

[Edoardo Lolletti]

(Well, my response had the quotes messed up)

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Dão Gottwald [:dao]]

Based on what emilio said, I don't think we should add an about:config preference for this.