1934204 - Copy Clean Link: Reevaluate keyboard shortcut after rename from "Copy [Link] Without Site Tracking"

Status: RESOLVED WONTFIX

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Manuel Bucher [:manuel]]

Copy Without Site Tracking was present in two context menus and had two different keyboard shortcuts:

• u when right clicking on a link.
• n when right clicking on a selected link in the address bar.

u isn't part of the string anymore after the rename to "Copy Clean Link". I think it is worth considering changing to n to be consistent with the address bar. Or both to c, because it is free in both context. C is currently used for Copy in the Address bar.

I'd love to hear from accessible team on their recommendation how to choose the keyboard shortcut or if we should prefer keeping the current one due to users needing to relearn if we change:

Setting accessible review flags according to https://firefox-source-docs.mozilla.org/bug-mgmt/processes/accessibility-review.html

Comment 1

[Manuel Bucher [:manuel]]

Attachment: copy-clean-link.jpg

Comment 2

[Manuel Bucher [:manuel]]

Attachment: Bug 1934204 - Copy Clean Link: Change keyboard shortcut from 'u' to 'C' when right clicking on a link r=#anti-tracking!

'u' isn't part of the string in the context menu anymore after the
rename from "Copy Link Without Site Tracking" to "Copy Clean Link".

The keyboard shortcut for the address bar for "Copy Clean Link" stays at
'n' making both keyboard shortcuts consistent.

Copy Link Without Site Tracking has been around since Fx120 released
on November 21, 2023. So hasn't been that long in the grand scheme of
things.

On one hand, we like to avoid breaking muscle memory. On the other hand,
having access keys that aren't part of the item name makes them
difficult to learn/discover. Inconsistency between app sections also
isn't great.

The consesus after reaching out to #accessibility team was that changing
to 'n' makes most sense.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d225e9dea8be
Copy Clean Link: Change keyboard shortcut from 'u' to 'n' when right clicking on a link r=anti-tracking-reviewers,fluent-reviewers,pbz,flod

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_contextmenu.js

Backout link

Push with failures

Failure log

Comment 5

[Manuel Bucher [:manuel]]

It seems like 'n' isn't free after all: browser/locales/en-US/browser/translations.ftl:172-198. Good that we have test coverage. I thought I checked that it's not in use.

Comment 6

[Manuel Bucher [:manuel]]

There aren't many access keys left. I only see upper case C that could be used when right clicking on a link (that is part of the string "Copy Clean Link"). But that is used for normal copy in the address bar. Not sure if there is a good solution or if I should close as WONTFIX reaching out to the accessibility team again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3b3fa7a28a0
Copy Clean Link: Change keyboard shortcut from 'u' to 'C' when right clicking on a link r=anti-tracking-reviewers,fluent-reviewers,pbz,flod

Comment 8

[Manuel Bucher [:manuel]]

Note there doesn't seem to be any difference between upper and lower case letters.

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e3b3fa7a28a0

Comment 10

[Manuel Bucher [:manuel]]

Please decide whether this is relevant enough. Accessiblity team showed interest in mentioning this release notes, but they weren't sure themselves whether this qualifies. Also not that it is only the context menu when right clicking on a link in document. Unfortunatly I couln't make it consistent with the urlbar shortcut. That one stays on n and I don't know if the context menu on links has a name or how and whether we need to describe it in more detail.

Release Note Request (optional, but appreciated)
[Why is this notable]: This is breaking change for keyboard users. I'd like to append a small note to the existing "rename 'Copy Clean Link' item".
[Affects Firefox for Android]: No
[Suggested wording]: [..] With the rename the accesskey in the context menu has changed from u to c to keep it part of the string and therefore more discoverable.
[Links (documentation, blog post, etc)]:

Comment 11

[Manuel Bucher [:manuel]]

I reset the request for release-notes due to uncertainty right now on whether switching back due to Bug 1933520 not being able to use C as accesskey. I might back out the patch and use u in both places.

Comment 12

[amarc]

Backed out changeset e3b3fa7a28a0 by developer request : https://hg.mozilla.org/integration/autoland/rev/2ab6f04ff3f8175684b712fc28e97b2037ef5a6e

Comment 13

[Manuel Bucher [:manuel]]

Thanks for backing out. Closing as WONTFIX now, due to no other letter in "Copy Clean Link" being collision free when also including the menu item on text links that aren't html links. Therefore, keeping it on u is most consistent and doesn't break muscle memory.