Closed Bug 1934220 Opened 10 days ago Closed 9 days ago

[wpt-sync] Sync PR 49440 - Implement whole-value attr-tainting for custom properties

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49440 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49440
Details from upstream follow.

Munira Tursunova <moonira@google.com> wrote:

Implement whole-value attr-tainting for custom properties

With the recent changes in attr spec, attr value tainting show work as
follows:

  1. attr() substitution value might have multiple tokens and all of them
    should be tainted.
  2. If parts of custom property is tainted, the whole custom property
    becomes tainted.
  3. For registered custom property with \<url> syntax, tainted values
    should be IACVT.

This CL replaces tainted comment approach to address to cases above.

Bug: 370002411, 40320391
Change-Id: I59c24b6ebee24a1df082f54f6287058066e738a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037885
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Munira Tursunova \<moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1389723}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
PASS: 67
FAIL: 90

Chrome

OK : 3
PASS: 68
FAIL: 89

Safari

OK : 3
PASS: 69
FAIL: 88

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-values/attr-all-types.html [wpt.fyi]
    • CSS Values and Units Test: attr: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Values and Units Test: attr 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 2: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Values and Units Test: attr 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 4: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 5: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 6: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 7: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 8: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 9: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 10: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 11: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 12: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 13: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 14: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 15: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 16: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 17: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 18: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 19: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 20: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 21: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 22: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 23: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 24: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 25: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 26: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 27: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 28: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 29: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 32: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 34: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 35: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 36: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 37: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 38: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 39: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 40: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 41: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 42: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 43: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 44: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 45: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 46: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 47: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 48: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 49: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 50: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 51: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 52: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 53: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 54: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 55: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 56: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 57: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 58: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 59: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 60: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 61: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 62: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 63: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 64: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 65: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 66: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 67: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 68: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 69: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 70: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 71: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 80: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 81: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 82: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 83: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-security.html [wpt.fyi]
    • CSS Values and Units Test: attr() security limitations: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 5: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 6: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 8: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 9: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 12: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 14: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 15: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 16: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 18: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 19: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 20: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 21: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 23: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() security limitations 24: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-universal-selector.html [wpt.fyi]
    • CSS Values and Units Test: attr() security limitations in universal selector : FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2da7cadd85d7 [wpt PR 49440] - Implement whole-value attr-tainting for custom properties, a=testonly https://hg.mozilla.org/integration/autoland/rev/b74ebc8e5c92 [wpt PR 49440] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2da7cadd85d7
https://hg.mozilla.org/mozilla-central/rev/b74ebc8e5c92

Status: NEW → RESOLVED
Closed: 9 days ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.