1934244 - [wpt-sync] Sync PR 49441 - Fix crash during serialization of the font shorthand.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49441 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49441
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Fix crash during serialization of the font shorthand.

It's not clear whether calc() expressions should be converted into
font keywords; not doing it seems like the most consistent handling,
given that calc() is never converted into literals anywhere else,
but it clashes with existing practice.

Bug: 40946458
Change-Id: I60c4fa354ec016ceeb872b7dabbef14d69412814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6057817
Commit-Queue: Steinar H Gunderson \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1389776}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2427b205e71154fbbb34ed7c23f02f1aa3b3326f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS: 3
FAIL: 1

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-fonts/font-shorthand-serialization-font-stretch.html [wpt.fyi]
  • calc() transformation into keywords: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3fb681e5551
[wpt PR 49441] - Fix crash during serialization of the font shorthand., a=testonly
https://hg.mozilla.org/integration/autoland/rev/b7c60abebb73
[wpt PR 49441] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d3fb681e5551
https://hg.mozilla.org/mozilla-central/rev/b7c60abebb73