193426 - Button text should not extend into "endcap" widget segment

Status: RESOLVED WORKSFORME

(Camino Graveyard :: HTML Form Controls, defect, P4)

Description

[Chris Meiering]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20030211 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20030211 Chimera/0.6+

Sometimes the width of submit buttons are smaller than the height. This
leads to an unpolished appearance that can be seen in just about any
submit button labeled "Go". For example http://www.pubmed.gov/ The "Go" button
at the top center should not be Taller than it is Wide.

Reproducible: Always

Steps to Reproduce:
1.Go to a form with a submit button labelled "Go"
2.Look at Go Button.
3.Notice it is oval, not round.



Expected Results:  
The smallest buttons should have the text presented in a horizontal aqua button,
then rounded endcaps should be added. Safari and Omniweb render this type of
button correctly. 

Not sure if this is a dupe of bug #188252, "make button widgets smaller by
default". It seems like it should be separate as this shows a problem in how
buttons are created. 

I would propose that submit buttons consist of three parts. 
EndCap-Center-EndCap

Text should only be presented in the "Center" region.

Comment 1

[Ari]

Attachment: patch

Comment 2

[Ari]

Standard Aqua buttons should always be "pill-shaped", not round or even oval-shaped.

Comment 3

[Greg K.]

I think he's probably right. For example, see the "About This Mac" dialog's
"More Info..." button.

Comment 4

[Greg K.]

Attachment: XHTML testcase with BUTTON elements

Comment 5

[Greg K.]

Making this change would also enable the buttons to be shorter by default.
They're perhaps a bit tall now.

Comment 6

[Ari]

Aqua has two relevant kinds of buttons: push buttons and bevel buttons. Push
buttons only contain text and are always pill-shaped whereas bevel buttons are
rectangular, can contain content such as icons, and can have any dimensions.

I think that since <button> elements meet the latter criteria, they really
should be bevel buttons anyway. So, I think this discussion should be confined
to <input> elements.

Comment 7

[Ari]

This has been fixed by the new form controls patch.

Comment 8

[Greg K.]

*** Bug 199797 has been marked as a duplicate of this bug. ***

Comment 9

[Greg K.]

This needs to be duped per comment 7.

Comment 10

[Jasper]

Ari is this issue/bug fixed or do we want to keep this bug open to discuss the
issues mentioned in Comment #6 ?

Comment 11

[Simon Fraser [no longer active]]

We need to style <button> too.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #11)
> We need to style <button> too.

Stuart was doing some <button> stuff in bug 205136 but things got all tangled,
it looks like.

This bug, as described in the summary and comment 0 (and the testcase in comment
4) is FIXED, as noted in comment 7.  Should styling <button> move to bug 205136
or get a new bug (so we can close this one)?

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Styling <button>s is now covered by bug 309556.  Closing per comment 12.