Closed Bug 1934375 Opened 3 months ago Closed 14 days ago

Picture in picture showing window decorations (shadows and rounded corners) on windows

Categories

(Toolkit :: Picture-in-Picture, defect)

Firefox 135
defect

Tracking

()

VERIFIED FIXED
136 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox133 --- unaffected
firefox134 --- unaffected
firefox135 --- verified
firefox136 --- verified

People

(Reporter: bmo, Assigned: emilio, NeedInfo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

  1. Play a video in Firefox
  2. Open picture in picture mode

Actual results:

Picture in picture window is showing window decorations (border, round corners)

Expected results:

Picture in picture windows doesn't show these window decorations.
Personally, I think it looks better this way, but from the comments in the regressing change it doesn't seem intentional.

Mozregression points to:
Bug 1932600 - Simplify chrome attribute handling. r=smaug,dao

Make them work like html boolean attributes consistently.

Nothing sets these to false afaict, we just remove them when needed
already.

Differential Revision: https://phabricator.services.mozilla.com/D229768

Keywords: regression
Regressed by: 1932600
Status: UNCONFIRMED → NEW
Component: Untriaged → Widget: Win32
Ever confirmed: true
Product: Firefox → Core

Set release status flags based on info from the regressing bug 1932600

:emilio, since you are the author of the regressor, bug 1932600, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Yeah, that was kind of an intentional change (and matches macOS). Curious, do you expect no decorations? If so, why?

Flags: needinfo?(emilio) → needinfo?(winson.wen1)

Ah I see you mention in comment 0 that it looks better this way and you weren't sure it was intentional.

It was, but it was discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1931747#c16 which is not where the change landed after all.

So closing as intended.

Status: NEW → RESOLVED
Closed: 3 months ago
Flags: needinfo?(winson.wen1)
Resolution: --- → INVALID

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Yeah, that was kind of an intentional change (and matches macOS). Curious, do you expect no decorations? If so, why?

I am concerned about the shadows around the PiP window.
Especially when the PiP is placed in the upper left corner, its shadow covers the content below it, making it an eyesore.

If possible, I would like to eliminate the shadow like before.

Ok, let's reopen. Alice, you mean on win11 or win10?

I personally think it looks nicer that way with the rounded corners and such. But that is the win11 effect, probably in win10 the window is still square? I see the point of the shadow maybe being a bit annoying if we're keeping the square window...

We can trivially get the old behavior by using hidechrome="true" on the player window. So it's more of a UX/UI question, rather than a platform bug. Moving to the PiP component.

Mike, do you know who would be the right person to make such a call?

Status: RESOLVED → REOPENED
Component: Widget: Win32 → Picture-in-Picture
Flags: needinfo?(mconley)
Flags: needinfo?(alice0775)
Product: Core → Toolkit
Resolution: INVALID → ---
Summary: Picture in picture showing window decorations → Picture in picture showing window decorations (shadows and rounded corners) on windows

I am on Windows 11.
But in Windows 10, the drop shadow width is narrower than in Windows 11, so I think this may not be as much of a concern.

Flags: needinfo?(alice0775)

Workaround: disable window shadows completely
1.Open Visual Effects Performance Options (SystemPropertiesPerformance.exe).
2 Check (enable - default) or uncheck (disable) Show shadows under windows

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

Mike, do you know who would be the right person to make such a call?

This is probably in the PM or UX wheelhouse. Let's see what Ania thinks!

Flags: needinfo?(mconley) → needinfo?(asafko)
See Also: → 1944255

This used to happen via custom nonclient margins.

I was hopping to get bug 1934760 fixed by now, but that is blocked in
some Linux fixes, in bug 581863.

For now this restores the behavior of not showing any window decorations
on PIP windows.

Assignee: nobody → emilio

Comment on attachment 9462399 [details]
Bug 1934375 - Take over whole non-client area for PiP windows again, for now. r=#win-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: This fixes bug 1934760 in a safer way to avoid shipping that regression to users.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: bug 1934760 comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Targeted fix, plus adds a pref just in case.
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9462399 - Flags: approval-mozilla-release?
Flags: qe-verify+
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3152949b0d5 Take over whole non-client area for PiP windows again, for now. r=win-reviewers,gstoll

Comment on attachment 9462399 [details]
Bug 1934375 - Take over whole non-client area for PiP windows again, for now. r=#win-reviewers

Approved for 135.0rc2.

Attachment #9462399 - Flags: approval-mozilla-release? → approval-mozilla-release+
Status: REOPENED → RESOLVED
Closed: 3 months ago14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
QA Whiteboard: [qa-triaged]

Reproduced the issue on Firefox 135.0a1 (2024-11-30) on Windows 10 by following the infos provided in Comment 0 and Comment 10.

The pip window has square borders on Windows 10 and 11 and will snap correctly to the bottom right part of the screen on Firefox 135.0 and Firefox 136.0a1 (2025-01-31).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
See Also: → 1934760
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: