Closed
Bug 1934475
Opened 3 months ago
Closed 1 month ago
Git lander Github app auth
Categories
(Conduit :: Lando, enhancement)
Conduit
Lando
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: shtrom, Assigned: shtrom)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•3 months ago
|
||
The lando git lander should authenticate to GitHub as an app with a token.
Assignee | ||
Updated•3 months ago
|
Type: defect → enhancement
Assignee | ||
Updated•3 months ago
|
Assignee: nobody → omehani
Assignee | ||
Comment 2•3 months ago
|
||
This could be useful https://github.com/mozilla-releng/simple-github
Comment 3•2 months ago
|
||
Is this something that blocks our production deployment & migration? If so then I'd like to move it under bug 1863519. Thanks!
Flags: needinfo?(zeid)
Flags: needinfo?(omehani)
Assignee | ||
Comment 4•2 months ago
|
||
I'd say it blocks the Git migration, but not the production deployment of the new lando for Hg repos.
Flags: needinfo?(omehani)
Assignee | ||
Updated•2 months ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•2 months ago
•
|
||
- Test org: https://github.com/bug1934475
- Test app https://github.com/organizations/bug1934475/settings/installations/58958083
- Deactivated WebHook
- Add RW Contents repo permission
- created private key
- Installed to test-repo fork https://github.com/organizations/bug1934475/settings/installations/58958083
- Got a PAT
Permdict: {}
response.headers={'Date': 'Mon, 30 Dec 2024 01:42:32 GMT', 'Content-Type': 'application/json; charset=utf-8', 'Content-Length': '170', 'Cache-Control': 'public, max-age=60, s-maxage=60', 'Vary': 'Accept,Accept-Encoding, Accept, X-Requested-With', 'ETag': '"58620b4f917585801e9f5fb993f4dc85e0fbf5409bc5f7e470cc989f9b9d9149"', 'X-GitHub-Media-Type': 'github.v3; format=json', 'x-github-api-version-selected': '2022-11-28', 'Access-Control-Expose-Headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', 'Access-Control-Allow-Origin': '*', 'Strict-Transport-Security': 'max-age=31536000; includeSubdomains; preload', 'X-Frame-Options': 'deny', 'X-Content-Type-Options': 'nosniff', 'X-XSS-Protection': '0', 'Referrer-Policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', 'Content-Security-Policy': "default-src 'none'", 'Server': 'github.com', 'X-GitHub-Request-Id': 'BBA2:427DF:1D589D4:23B18F9:6771FA88'}
response.json()={'token': 'ghs_XXX', 'expires_at': '2024-12-30T02:42:32Z', 'permissions': {'contents': 'write', 'metadata': 'read'}, 'repository_selection': 'all'}
ghs_XXX
- Can push and pull with https://git:ghs_XXX@github.com/bug1934475/test-repo
Assignee | ||
Comment 7•2 months ago
|
||
Comment 8•2 months ago
|
||
Assignee | ||
Updated•1 month ago
|
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•