Closed
Bug 1934700
Opened 1 year ago
Closed 1 year ago
Replace hardcoded hr color value with a token in moz-page-nav
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: hjones, Assigned: cmeade)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp] [acorntractors])
Attachments
(1 file)
Currently we use a hard coded hex color in moz-page-nav to style the <hr> between the top links and the bottom buttons. When that was being implemented we didn't have a token for it and didn't want to block on that, so landed the fix for bug 1927211 with the hex value. We should revisit this and consult with design to add a proper token.
|
||
Updated•1 year ago
|
|
||
Updated•1 year ago
|
Whiteboard: [recomp] → [recomp] [acorntractors]
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → cmeade
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•1 year ago
•
|
||
Added
--color-gray-40token
Changed
--border-colorto use Gray 40 instead of the hex value- Page Nav widget to use the now accurate
--border-colortoken, also improves dark mode
|
||
Updated•1 year ago
|
Attachment #9502944 -
Attachment description: Bug 1934700 - Use border token in Page Nav. r=#reusable-components-reviewers,hjones,jules,julian → Bug 1934700 - Use border token in Page Nav. r=#reusable-components-reviewers,hjones,jules
Pushed by hjones@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f4847ec9c5af
https://hg.mozilla.org/integration/autoland/rev/01332227616b
Use border token in Page Nav. r=hjones,reusable-components-reviewers,desktop-theme-reviewers
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
|
||
Updated•11 months ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•