Closed Bug 1934868 Opened 2 months ago Closed 2 months ago

Manage Cookies and Site Data dialog does not delete cached data

Categories

(Toolkit :: Data Sanitization, defect, P1)

Firefox 132
defect

Tracking

()

VERIFIED FIXED
135 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox133 --- wontfix
firefox134 + verified
firefox135 --- verified

People

(Reporter: 6k64x4ma, Assigned: emz)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

  1. Browse for a while.
  2. Open about:cache and note the number of entries on disk.
  3. Go to about:preferences#privacy and click "Manage Data..." button.
  4. Remove some (but not all) sites, click "Save Changes" then "Remove".
  5. Reload about:cache and compare the value with the old one.

Actual results:

  • Network cache is not removed.

Expected results:

  • I'm not sure if it's an intentional change in bug 1915608, but probably not.
    Because selecting "Remove All Shown" in step 4 clears all site data and cache.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=20292c37151c3b19191d8d6cc523a9b07552fa20&tochange=772c388ddebf76fb3571743104e23909c6126b33

Keywords: regression
Regressed by: 1915608

:pbz, since you are the author of the regressor, bug 1915608, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(pbz)

Thanks for the report. We missed a flag when consolidating the site data flags. I'll submit a patch shortly.

Assignee: nobody → pbz
Severity: -- → S2
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(pbz)
Priority: -- → P1

Set release status flags based on info from the regressing bug 1915608

Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cfec64949a58 Include CLEAR_ALL_CACHES in SiteDataManager clear method. r=anti-tracking-reviewers,timhuang

[Tracking Requested - why for this release]:
Regression which we would like to fix in beta as well. I'll submit an uplift request once this lands.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch

The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(pbz)
Attachment #9441640 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Users won't be able to clear cache for specific sites. Clearing cache for all sites is still possible through workarounds.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: see comment 0
  • Risk associated with taking this patch: low
  • Explanation of risk level: low because we're just reintroducing a flag we previously dropped by accident.
  • String changes made/needed: no
  • Is Android affected?: no
Flags: qe-verify+
Flags: needinfo?(pbz)
QA Whiteboard: [qa-triaged]

I was able to reproduce the issue on Ubuntu 24.04 using Firefox build 134.0b5.
Verified as fixed on Ubuntu 24.04/Windows 10 using Firefox build 135.0a1. Waiting for uplift on beta.

Attachment #9441640 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on Ubuntu 24.04/Windows 10 using Firefox build 134.0b7.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: