Manage Cookies and Site Data dialog does not delete cached data
Categories
(Toolkit :: Data Sanitization, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr128 | --- | unaffected |
firefox133 | --- | wontfix |
firefox134 | + | verified |
firefox135 | --- | verified |
People
(Reporter: 6k64x4ma, Assigned: emz)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:134.0) Gecko/20100101 Firefox/134.0
Steps to reproduce:
- Browse for a while.
- Open about:cache and note the number of entries on disk.
- Go to about:preferences#privacy and click "Manage Data..." button.
- Remove some (but not all) sites, click "Save Changes" then "Remove".
- Reload about:cache and compare the value with the old one.
Actual results:
- Network cache is not removed.
Expected results:
- I'm not sure if it's an intentional change in bug 1915608, but probably not.
Because selecting "Remove All Shown" in step 4 clears all site data and cache.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=20292c37151c3b19191d8d6cc523a9b07552fa20&tochange=772c388ddebf76fb3571743104e23909c6126b33
Comment 1•2 months ago
|
||
:pbz, since you are the author of the regressor, bug 1915608, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Assignee | ||
Comment 2•2 months ago
|
||
Thanks for the report. We missed a flag when consolidating the site data flags. I'll submit a patch shortly.
Assignee | ||
Comment 3•2 months ago
|
||
Comment 4•2 months ago
|
||
Set release status flags based on info from the regressing bug 1915608
Assignee | ||
Comment 6•2 months ago
|
||
[Tracking Requested - why for this release]:
Regression which we would like to fix in beta as well. I'll submit an uplift request once this lands.
Updated•2 months ago
|
Comment 7•2 months ago
|
||
bugherder |
Comment 8•2 months ago
|
||
The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox134
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 9•2 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D230952
Updated•2 months ago
|
Comment 10•2 months ago
|
||
beta Uplift Approval Request
- User impact if declined: Users won't be able to clear cache for specific sites. Clearing cache for all sites is still possible through workarounds.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: see comment 0
- Risk associated with taking this patch: low
- Explanation of risk level: low because we're just reintroducing a flag we previously dropped by accident.
- String changes made/needed: no
- Is Android affected?: no
Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
Comment 11•2 months ago
|
||
I was able to reproduce the issue on Ubuntu 24.04 using Firefox build 134.0b5.
Verified as fixed on Ubuntu 24.04/Windows 10 using Firefox build 135.0a1. Waiting for uplift on beta.
Updated•2 months ago
|
Comment 12•2 months ago
|
||
uplift |
Updated•2 months ago
|
Comment 13•2 months ago
|
||
Verified as fixed on Ubuntu 24.04/Windows 10 using Firefox build 134.0b7.
Description
•