displayed_notification filtering for in-app notifications is inverted
Categories
(Thunderbird :: General, defect, P1)
Tracking
(thunderbird134+ fixed, thunderbird135 fixed)
People
(Reporter: freaktechnik, Assigned: freaktechnik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
corey
:
approval-comm-beta+
|
Details | Review |
The displayed_notifications filter matches if none of the listed IDs have been shown, which is the inverted behavior from what was specified or any other property behaves.
Assignee | ||
Comment 1•2 months ago
|
||
Assignee | ||
Updated•2 months ago
|
Assignee | ||
Comment 2•2 months ago
|
||
Comment on attachment 9441311 [details]
Bug 1934871 - Fix displayed_notifications filter logic. r=tobyp,arschmitz
[Approval Request Comment]
Regression caused by (bug #): bug 1918831
User impact if declined: We will have to manage separate notifications for beta that doesn't have this fix.
Testing completed (on c-c, etc.): Automated tests
Risk to taking this patch (and alternatives if risky): Low risk, only inverts the logic for a notification targeting filter.
Comment 3•2 months ago
|
||
Comment on attachment 9441311 [details]
Bug 1934871 - Fix displayed_notifications filter logic. r=tobyp,arschmitz
[Triage Comment]
Approved for beta
Updated•2 months ago
|
Pushed by toby@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/f5d3bcba566a
Fix displayed_notifications filter logic. r=tobyp,arschmitz
Comment 5•2 months ago
|
||
bugherder uplift |
Thunderbird 134.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/5114040eb857
Comment 7•2 months ago
|
||
bugherder uplift |
Thunderbird 134.0b3 (post):
https://hg.mozilla.org/releases/comm-beta/rev/498a35196605
Description
•