Closed Bug 1934871 Opened 2 months ago Closed 2 months ago

displayed_notification filtering for in-app notifications is inverted

Categories

(Thunderbird :: General, defect, P1)

Thunderbird 134
Desktop
All

Tracking

(thunderbird134+ fixed, thunderbird135 fixed)

RESOLVED FIXED
135 Branch
Tracking Status
thunderbird134 + fixed
thunderbird135 --- fixed

People

(Reporter: freaktechnik, Assigned: freaktechnik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The displayed_notifications filter matches if none of the listed IDs have been shown, which is the inverted behavior from what was specified or any other property behaves.

Target Milestone: --- → 135 Branch

Comment on attachment 9441311 [details]
Bug 1934871 - Fix displayed_notifications filter logic. r=tobyp,arschmitz

[Approval Request Comment]
Regression caused by (bug #): bug 1918831
User impact if declined: We will have to manage separate notifications for beta that doesn't have this fix.
Testing completed (on c-c, etc.): Automated tests
Risk to taking this patch (and alternatives if risky): Low risk, only inverts the logic for a notification targeting filter.

Attachment #9441311 - Flags: approval-comm-beta?

Comment on attachment 9441311 [details]
Bug 1934871 - Fix displayed_notifications filter logic. r=tobyp,arschmitz

[Triage Comment]
Approved for beta

Attachment #9441311 - Flags: approval-comm-beta? → approval-comm-beta+

Pushed by toby@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/f5d3bcba566a
Fix displayed_notifications filter logic. r=tobyp,arschmitz

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Pushed by brendan@thunderbird.net: https://hg.mozilla.org/comm-central/rev/e3cb06134eaa Fix linting errors in test file. rs=lint DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: