Closed Bug 1935203 Opened 3 months ago Closed 3 months ago

Update android nightly application-services version bump to new version 372bee8fbb1fbe90a75da7ffcf924311037370b9 from 2024-12-04 16:27:20

Categories

(Fenix :: General, enhancement)

All
Unspecified
enhancement

Tracking

(firefox135 affected)

RESOLVED DUPLICATE of bug 1935282
Tracking Status
firefox135 --- affected

People

(Reporter: update-bot, Assigned: update-bot)

References

Details

(Whiteboard: [3pl-filed][task_id: JkzfUmawRfmU85CQG1JwvA])

Attachments

(1 obsolete file)

This update covers 14 commits, including 6 new upstream commits I've never filed a bug on before. (They're the top 6.). Here are the overall diff statistics, and then the commit information.


mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


372bee8fbb1fbe90a75da7ffcf924311037370b9 by Mark Hammond <mhammond@skippinet.com.au>

https://github.com/mozilla/application-services/commit/372bee8fbb1fbe90a75da7ffcf924311037370b9
Authored: 2024-12-03 21:20:45 -0500
Committed: 2024-12-04 15:31:31 +0000

Remove cargo workspace dependencies.

Once in m-c, many of our crates need to be excluded from the main workspace,
which means they can't use workspace deps. So we don't bother using them anywhere.

Files Modified:

  • Cargo.toml
  • components/as-ohttp-client/Cargo.toml
  • components/autofill/Cargo.toml
  • components/crashtest/Cargo.toml
  • components/fxa-client/Cargo.toml
  • components/logins/Cargo.toml
  • components/nimbus/Cargo.toml
  • components/places/Cargo.toml
  • components/push/Cargo.toml
  • components/relevancy/Cargo.toml
  • components/remote_settings/Cargo.toml
  • components/search/Cargo.toml
  • components/suggest/Cargo.toml
  • components/support/error/Cargo.toml
  • components/support/guid/Cargo.toml
  • components/support/interrupt/Cargo.toml
  • components/support/nimbus-fml/Cargo.toml
  • components/support/rc_crypto/nss/nss_sys/Cargo.toml
  • components/support/rust-log-forwarder/Cargo.toml
  • components/support/sql/Cargo.toml
  • components/support/types/Cargo.toml
  • components/sync15/Cargo.toml
  • components/sync_manager/Cargo.toml
  • components/tabs/Cargo.toml
  • components/webext-storage/Cargo.toml
  • examples/autofill-utils/Cargo.toml
  • examples/places-autocomplete/Cargo.toml
  • examples/sync-pass/Cargo.toml
  • testing/separated/places-tests/Cargo.toml
  • tools/embedded-uniffi-bindgen/Cargo.toml
  • tools/uniffi-bindgen-library-mode/Cargo.toml

e40ecd0af5d1f67733384ff0e77f4167fc1da9dc by Charlie Humphreys <chumphreys@mozilla.com>

https://github.com/mozilla/application-services/commit/e40ecd0af5d1f67733384ff0e77f4167fc1da9dc
Authored: 2024-12-03 13:46:16 -0600
Committed: 2024-12-04 15:01:00 +0000

update getLocaleTag in Nimbus swift to be public

Files Modified:

  • CHANGELOG.md
  • components/nimbus/ios/Nimbus/Utils/Utils.swift

ab44248d1d0acb4dc989d5887d04d8c4629dcf1e by Mark Banner <standard8@mozilla.com>

https://github.com/mozilla/application-services/commit/ab44248d1d0acb4dc989d5887d04d8c4629dcf1e
Authored: 2024-12-03 21:48:03 -0500
Committed: 2024-12-04 14:27:23 +0000

Fix issues with trailing whitespace/windows line endings/empty lines at ends of files

Files Modified:

  • components/logins/src/db.rs
  • components/nimbus/README.md
  • components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/FeatureVariablesTest.kt
  • components/nimbus/tests/experiments/README.md
  • components/nimbus/tests/experiments/invalid-experiment-missing-slug.json
  • components/nimbus/tests/experiments/secure-gold.json
  • components/places/doc/dummy_urls.md
  • components/relevancy/src/ingest.rs
  • components/remote_settings/Cargo.toml
  • components/remote_settings/uniffi.toml
  • components/suggest/uniffi.toml
  • components/support/error/README.md
  • components/support/error/tests/handle_error_on_non_functions.rs
  • components/support/error/tests/macro_arguments.rs
  • components/support/error/tests/returns_not_result.rs
  • components/support/error/tests/returns_result_but_incorrect_error.rs
  • components/support/error/tests/returns_result_but_not_error.rs
  • components/support/nimbus-cli/README.md
  • components/support/nimbus-cli/assets/li-template.html
  • components/support/nimbus-cli/assets/style.css
  • components/support/nimbus-fml/ExperimentFeatureManifest.schema.json
  • components/support/nimbus-fml/askama.toml
  • components/support/nimbus-fml/fixtures/android/config.yaml
  • components/support/nimbus-fml/fixtures/fe/importing/coenrolling/app.fml.yaml
  • components/support/nimbus-fml/fixtures/fe/no_about_no_channels.yaml
  • components/support/nimbus-fml/src/backends/kotlin/templates/EnumTemplate.kt
  • components/support/viaduct-reqwest/Cargo.toml
  • docs/adding-docs.md
  • docs/adr/0001-update-logins-api.md
  • docs/adr/0004-early-startup-experiments.md
  • docs/adr/0005-remote-settings-client.md
  • docs/adr/0008-fts-prefix-config.md
  • docs/build-and-publish-pipeline.md
  • docs/design/README.md
  • docs/design/megazords.md
  • docs/design/swift-package-manager.md
  • docs/design/test-faster.md
  • docs/howtos/locally-published-components-in-firefox-ios.md
  • docs/howtos/locally-published-components-in-focus-ios.md
  • docs/naming-conventions.md
  • libs/README.md
  • megazords/cirrus/tests/python-tests/resources/includes-and-imports/import1-include1.fml.yml
  • megazords/cirrus/tests/python-tests/resources/includes-and-imports/import1.fml.yml
  • megazords/cirrus/tests/python-tests/resources/includes-and-imports/include1.fml.yml
  • megazords/cirrus/tests/python-tests/resources/test-include-import.fml.yml
  • megazords/cirrus/tests/python-tests/resources/test-invalid.fml.yml
  • megazords/cirrus/tests/python-tests/resources/test.fml.yml
  • megazords/ios-rust/README.md
  • testing/separated/places-bench/fixtures/dummy_urls.json
  • testing/separated/places-tests/src/ios_history.rs
  • tools/loc_summary.py
  • tools/nimbus-gradle-plugin/src/main/resources/nimbus-gradle-plugin.properties

d64830531b17b1b298dfeeccd979a3965a4eb988 by Travis Long <tlong@mozilla.com>

https://github.com/mozilla/application-services/commit/d64830531b17b1b298dfeeccd979a3965a4eb988
Authored: 2024-12-03 11:37:28 -0600
Committed: 2024-12-04 12:10:21 +0000

Add sync ping registration prior to resetGlean calls

This is weird to do in other test classes calling resetGlean, but it's an unfortunate side effect of the new collection enabled mechanisms that'll be fixed up with https://bugzilla.mozilla.org/show_bug.cgi?id=1935001

Files Modified:

  • megazords/ios-rust/MozillaTestServices/MozillaTestServicesTests/NimbusTests.swift
  • megazords/ios-rust/MozillaTestServices/MozillaTestServicesTests/SyncManagerTelemetryTests.swift

a72489f0db9808f444bdacda88b51f5a03e8401d by Travis Long <tlong@mozilla.com>

https://github.com/mozilla/application-services/commit/a72489f0db9808f444bdacda88b51f5a03e8401d
Authored: 2024-12-03 09:29:29 -0600
Committed: 2024-12-04 12:10:21 +0000

Fix Sync Telemetry android tests to work with new Glean changes

Files Modified:

  • components/sync_manager/android/src/test/java/mozilla/appservices/syncmanager/SyncTelemetryTest.kt

86cb64d5e5b94a3e952a93b57f8f80a7fe9a43ae by Travis Long <tlong@mozilla.com>

https://github.com/mozilla/application-services/commit/86cb64d5e5b94a3e952a93b57f8f80a7fe9a43ae
Authored: 2024-12-02 07:52:53 -0600
Committed: 2024-12-04 12:10:21 +0000

Bug1933939 - Update Glean to v63.0.0

Files Modified:

  • CHANGELOG.md
  • components/external/glean
  • components/sync_manager/android/src/test/java/mozilla/appservices/syncmanager/SyncTelemetryTest.kt
  • gradle/libs.versions.toml
  • megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.pbxproj
  • megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
  • megazords/ios-rust/MozillaTestServices/MozillaTestServicesTests/SyncManagerTelemetryTests.swift

146830196cbc4e77f41f9120173a9803fcceddce by Mark Hammond <mhammond@skippinet.com.au>

https://github.com/mozilla/application-services/commit/146830196cbc4e77f41f9120173a9803fcceddce
Authored: 2024-12-03 11:42:59 -0500
Committed: 2024-12-04 03:38:07 +0000

Update Rust to 1.83, and fix clippy warnings from that version

Files Modified:

  • components/as-ohttp-client/Cargo.toml
  • components/autofill/Cargo.toml
  • components/autofill/src/sync/address/mod.rs
  • components/autofill/src/sync/credit_card/mod.rs
  • components/crashtest/Cargo.toml
  • components/fxa-client/Cargo.toml
  • components/fxa-client/src/internal/device.rs
  • components/fxa-client/src/internal/oauth.rs
  • components/fxa-client/src/internal/profile.rs
  • components/logins/Cargo.toml
  • components/logins/src/sync/engine.rs
  • components/nimbus/Cargo.toml
  • components/nimbus/src/stateful/behavior.rs
  • components/nimbus/src/stateful/enrollment.rs
  • components/places/Cargo.toml
  • components/places/src/api/matcher.rs
  • components/places/src/bookmark_sync/engine.rs
  • components/places/src/bookmark_sync/record.rs
  • components/places/src/db/tx/coop_transaction.rs
  • components/places/src/db/tx/mod.rs
  • components/places/src/history_sync/plan.rs
  • components/places/src/match_impl.rs
  • components/places/src/storage/bookmarks.rs
  • components/places/src/storage/bookmarks/json_tree.rs
  • components/places/src/storage/bookmarks/root_guid.rs
  • components/places/src/storage/history_metadata.rs
  • components/places/src/storage/tags.rs
  • components/places/src/types.rs
  • components/push/Cargo.toml
  • components/push/src/internal/crypto.rs
  • components/relevancy/src/ranker.rs
  • components/suggest/src/fakespot.rs
  • components/suggest/src/yelp.rs
  • components/support/error/Cargo.toml
  • components/support/error/macros/src/lib.rs
  • components/support/error/src/lib.rs
  • components/support/firefox-versioning/src/version.rs
  • components/support/guid/src/serde_support.rs
  • components/support/nimbus-cli/src/version_utils.rs
  • components/support/nimbus-fml/Cargo.toml
  • components/support/nimbus-fml/src/backends/kotlin/gen_structs/object.rs
  • components/support/nimbus-fml/src/backends/kotlin/mod.rs
  • components/support/nimbus-fml/src/backends/swift/gen_structs/object.rs
  • components/support/nimbus-fml/src/backends/swift/mod.rs
  • components/support/nimbus-fml/src/command_line/workflows.rs
  • components/support/nimbus-fml/src/defaults/merger.rs
  • components/support/nimbus-fml/src/editing/values_finder.rs
  • components/support/nimbus-fml/src/intermediate_representation.rs
  • components/support/rc_crypto/nss/nss_sys/Cargo.toml
  • components/support/rc_crypto/nss/systest/src/main.rs
  • components/support/rc_crypto/src/contentsignature.rs
  • components/support/rust-log-forwarder/Cargo.toml
  • components/support/sql/src/conn_ext.rs
  • components/support/sql/src/repeat.rs
  • components/sync15/Cargo.toml
  • components/sync15/src/bso/mod.rs
  • components/sync15/src/client/storage_client.rs
  • components/sync15/src/client/sync_multiple.rs
  • components/sync15/src/clients_engine/engine.rs
  • components/sync15/src/engine/mod.rs
  • components/sync15/src/telemetry.rs
  • components/sync_manager/Cargo.toml
  • components/tabs/Cargo.toml
  • components/webext-storage/Cargo.toml
  • examples/autofill-utils/src/autofill-utils.rs
  • examples/push-livetest/src/livetest.rs
  • rust-toolchain.toml

28c7e7386d34b76e8643b280458bc9d77d512253 by Mark Banner <standard8@mozilla.com>

https://github.com/mozilla/application-services/commit/28c7e7386d34b76e8643b280458bc9d77d512253
Authored: 2024-12-03 21:27:44 -0500
Committed: 2024-12-04 03:29:05 +0000

Add missing license headers

Files Modified:

  • automation/cargo-update-pr.py
  • automation/check_protobuf_files_current.py
  • automation/kotlin-components-docs/gradle.properties
  • automation/prepare-release.py
  • automation/publish_to_maven_local_if_modified.py
  • automation/shared.py
  • automation/smoke-test-android-components.py
  • automation/smoke-test-fenix.py
  • automation/smoke-test-fxios.py
  • automation/tag-release.py
  • components/as-ohttp-client/src/lib.rs
  • components/autofill/android/src/main/AndroidManifest.xml
  • components/fxa-client/android/src/main/AndroidManifest.xml
  • components/logins/android/src/main/AndroidManifest.xml
  • components/nimbus/android/src/main/AndroidManifest.xml
  • components/nimbus/src/metrics.rs
  • components/places/android/src/main/AndroidManifest.xml
  • components/push/android/src/main/AndroidManifest.xml
  • components/relevancy/src/bin/generate-test-data.rs
  • components/relevancy/src/ranker.rs
  • components/remote_settings/android/src/main/AndroidManifest.xml
  • components/suggest/android/src/main/AndroidManifest.xml
  • components/suggest/benches/benchmark_all.rs
  • components/support/android/src/main/AndroidManifest.xml
  • components/support/error/android/src/main/AndroidManifest.xml
  • components/support/find-places-db/src/lib.rs
  • components/support/nimbus-cli/assets/index.html
  • components/support/nimbus-cli/assets/li-template.html
  • components/support/nimbus-cli/assets/script.js
  • components/support/nimbus-cli/assets/style.css
  • components/support/nimbus-fml/src/backends/kotlin/templates/EnumTemplate.kt
  • components/support/nimbus-fml/src/backends/kotlin/templates/FeatureTemplate.kt
  • components/support/nimbus-fml/src/backends/kotlin/templates/ImportedModuleInitializationTemplate.kt
  • components/support/nimbus-fml/src/backends/kotlin/templates/ObjectTemplate.kt
  • components/support/rust-log-forwarder/android/src/main/AndroidManifest.xml
  • components/sync15/android/src/main/AndroidManifest.xml
  • components/sync_manager/android/src/main/AndroidManifest.xml
  • components/sync_manager/src/types.rs
  • components/tabs/android/src/main/AndroidManifest.xml
  • components/viaduct/android/src/main/AndroidManifest.xml
  • components/webext-storage/android/src/main/AndroidManifest.xml
  • docs/shared/a-s.css
  • docs/shared/tabs.js
  • gradle.properties
  • gradle/wrapper/gradle-wrapper.properties
  • megazords/full/android/src/main/AndroidManifest.xml
  • taskcluster/scripts/build-and-test-swift.py
  • taskcluster/scripts/deps-complete.py
  • taskcluster/scripts/nimbus-build.py
  • taskcluster/scripts/setup-branch-build-firefox-android.py
  • taskcluster/scripts/setup-branch-build-firefox-ios.py
  • tools/clean-gradle-autopublish.py
  • tools/clean.py
  • tools/loc_summary.py
  • tools/nimbus-gradle-plugin/src/main/resources/nimbus-gradle-plugin.properties
  • tools/update-moz-central-vendoring.py

c236057647fc5fdcaf74c0f0a5e964a99e022266 by Mark Banner <standard8@mozilla.com>

https://github.com/mozilla/application-services/commit/c236057647fc5fdcaf74c0f0a5e964a99e022266
Authored: 2024-12-03 17:05:10 -0500
Committed: 2024-12-04 02:10:13 +0000

Fix file permission issues

Files Modified:

  • docs/howtos/img/nss_tryserver_artifacts.png
  • taskcluster/scripts/toolchain/setup-fetched-rust-toolchain.sh
  • taskcluster/scripts/toolchain/setup-libs-ios.sh
  • taskcluster/test/params/relpro-promote.yml
  • taskcluster/test/params/relpro-ship.yml

4ccf7de4292dbe0a0580121baaf64fc9094043e4 by Mark Hammond <mhammond@skippinet.com.au>

https://github.com/mozilla/application-services/commit/4ccf7de4292dbe0a0580121baaf64fc9094043e4
Authored: 2024-12-03 10:55:17 -0500
Committed: 2024-12-03 20:12:08 +0000

Have nimbus depend on uuid=1.3 for consistency with m-c

Files Modified:

  • components/nimbus/Cargo.toml

9019fbec34ff526a2add38970411dcf6b8e1d4f1 by Mark Banner <standard8@mozilla.com>

https://github.com/mozilla/application-services/commit/9019fbec34ff526a2add38970411dcf6b8e1d4f1
Authored: 2024-11-25 13:48:07 +0000
Committed: 2024-12-03 20:10:54 +0000

Bug 1933217 - Implement suggestion and trending URL handling on the search engine selector.

Files Modified:

  • components/search/src/filter.rs
  • components/search/src/selector.rs

4d553248c4a27e5f5d69416444fb4368cbcab16f by Mark Hammond <mhammond@skippinet.com.au>

https://github.com/mozilla/application-services/commit/4d553248c4a27e5f5d69416444fb4368cbcab16f
Authored: 2024-12-03 13:09:41 -0500
Committed: 2024-12-03 18:54:40 +0000

Remove unused features from tabs and fxa-client

Files Modified:

  • components/fxa-client/src/internal/mod.rs
  • components/tabs/src/error.rs

55b551b35d4d363466c3ea2cd8d60f1da702476e by Mark Hammond <mhammond@skippinet.com.au>

https://github.com/mozilla/application-services/commit/55b551b35d4d363466c3ea2cd8d60f1da702476e
Authored: 2024-11-30 20:37:13 -0500
Committed: 2024-12-03 18:22:45 +0000

Update sql support crate to temporarily not depend on prettytable-rs.

prettytable-rs drags in dependencies we don't want in m-c (or, at least, which we
don't want to audit at this stage). We should work out an alternative, but this seems
fine in the short term.

Files Modified:

  • Cargo.lock
  • components/support/sql/Cargo.toml
  • components/support/sql/src/lib.rs
  • examples/places-utils/src/places-utils.rs

fc0d75b1debc6cbc9d409fc5fac2b389f839620e by Mark Hammond <mhammond@skippinet.com.au>

https://github.com/mozilla/application-services/commit/fc0d75b1debc6cbc9d409fc5fac2b389f839620e
Authored: 2024-12-02 22:24:02 -0500
Committed: 2024-12-03 15:29:40 +0000

Updates idna crate requirement to version 1

Also updates url from 2.5.0 to 2.5.4 (to also bring that along for
the idna upgrade) and cleans up some other url deps.

Brings both into line with m-c.

Files Modified:

  • Cargo.lock
  • DEPENDENCIES.md
  • components/places/Cargo.toml
  • components/remote_settings/Cargo.toml
  • components/sync15/Cargo.toml
  • components/tabs/Cargo.toml
  • components/viaduct/Cargo.toml
  • megazords/full/DEPENDENCIES.md
  • megazords/full/android/dependency-licenses.xml
  • megazords/ios-rust/DEPENDENCIES.md
  • megazords/ios-rust/focus/DEPENDENCIES.md
  • tools/dependency_summary.py

Duplicate of this bug: 1935066
Assignee: nobody → update-bot
Status: NEW → ASSIGNED

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Duplicate of bug: 1935282
Resolution: --- → DUPLICATE
Attachment #9441734 - Attachment is obsolete: true

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

  • toolchain-linux64-android-gradle-dependencies - 1 of 1 failed (failed: DT4ZM-C_Q6im8exT9Q-jJw)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: